Skip to content

[Security Solution][Resolver] Show all event counts on nodes #77819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 18, 2020
Merged

[Security Solution][Resolver] Show all event counts on nodes #77819

merged 13 commits into from
Sep 18, 2020

Conversation

@bkimmel
Copy link
Contributor

@bkimmel bkimmel commented Sep 17, 2020 •
edited
Loading

Summary

  1. Remove Submenu host buttons from Resolver Nodes
  2. Replace them with the group of pills they would show when clicked on (which will be visible now whenever their button would have been visible)

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@bkimmel bkimmel requested review from a team as code owners September 17, 2020 20:03
@bkimmel bkimmel added Feature:Resolver Security Solution Resolver feature release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Data Visibility Team managing the endpoint resolver labels Sep 17, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 17, 2020

Pinging @elastic/endpoint-app-team (Feature:Resolver)

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 17, 2020

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

@monina-n monina-n self-requested a review September 17, 2020 21:15
@bkimmel
Copy link
Contributor Author

bkimmel commented Sep 18, 2020

@elasticmachine merge upstream

@bkimmel
Copy link
Contributor Author

bkimmel commented Sep 18, 2020

@elasticmachine merge upstream

bkimmel
bkimmel commented Sep 18, 2020
View reviewed changes
x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts
const text = await (
await value.findByCssSelector('[class*="StyledLabelTitle"]')
)._webElement.getText();
const text = await value._webElement.getText();
Copy link
Contributor Author

@bkimmel bkimmel Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ addressed by #77895

@bkimmel
Copy link
Contributor Author

bkimmel commented Sep 18, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 18, 2020

merge conflict between base and head

oatkiller
oatkiller approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@oatkiller oatkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 18, 2020

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 10.1MB -6.7KB 10.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bkimmel bkimmel merged commit 060f089 into elastic:master Sep 18, 2020
@bkimmel bkimmel deleted the resolver/overrideOpenClose branch September 18, 2020 18:45
@bkimmel bkimmel mentioned this pull request Sep 21, 2020
Merged
bkimmel added a commit that referenced this pull request Sep 22, 2020
@bkimmel @elasticmachine
[Security Solution][Resolver] Show all event counts on nodes (#77819) (…
4a1a614 
…#78078)

* [Security Solution][Resolver] Show all event counts
Co-authored-by: Elastic Machine <[email protected]>
@jmikell821 jmikell821 mentioned this pull request Sep 23, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

+2 more reviewers

@oatkiller oatkiller oatkiller approved these changes

@monina-n monina-n monina-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Resolver Security Solution Resolver feature release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Data Visibility Team managing the endpoint resolver v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bkimmel @elasticmachine @kibanamachine @oatkiller @jonathan-buttner @kqualters-elastic @monina-n