-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[CSM] Url search #77516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[CSM] Url search #77516
Changes from 17 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
6bc0adf
WIp
shahzad31 1ec079d
Merge branch 'master' into url-search
shahzad31 860053b
add url search
shahzad31 b9acb06
Merge branch 'master' into url-search
shahzad31 c48e591
added test for url search
shahzad31 b1426d5
Merge branch 'master' into url-search
shahzad31 d146242
added a button
shahzad31 1aad1c4
Merge branch 'master' into url-search
shahzad31 88ed419
added query
shahzad31 b0f52bf
fix type
shahzad31 17a9627
Merge branch 'master' into url-search
shahzad31 a592dcf
improve test
shahzad31 691440f
update test and states
shahzad31 10ce21d
fix type
shahzad31 04f1637
improve formatting
shahzad31 eecc7ee
fix type
shahzad31 58b37b0
Merge branch 'master' into url-search
elasticmachine ba134db
Update x-pack/plugins/apm/e2e/cypress/integration/csm_dashboard.feature
shahzad31 a71619c
Update x-pack/plugins/apm/e2e/cypress/support/step_definitions/csm/ur…
shahzad31 6d06c0e
Update x-pack/plugins/apm/e2e/cypress/integration/csm_dashboard.feature
shahzad31 4f80373
Update x-pack/plugins/apm/e2e/cypress/support/step_definitions/csm/ur…
shahzad31 1c2859b
Merge branch 'master' into url-search
shahzad31 ecfc910
update label
shahzad31 fbd9ec8
Merge branch 'url-search' of https://github.com/shahzad31/kibana into…
shahzad31 5d00c79
reduce concurrency
shahzad31 90124f4
improve code owners
shahzad31 1897bd3
Merge branch 'master' into url-search
shahzad31 00d7283
update test
shahzad31 9551efe
fix broken e2e
shahzad31 a0ca1e1
Merge branch 'master' into url-search
shahzad31 a5c8775
update usage of selectable
shahzad31 369b505
type fix
shahzad31 ed58bd1
imrpove e2e test
shahzad31 7dbcc4b
Merge branch 'master' into url-search
shahzad31 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
x-pack/plugins/apm/e2e/cypress/support/step_definitions/csm/url_search_filter.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| import { When, Then } from 'cypress-cucumber-preprocessor/steps'; | ||
| import { DEFAULT_TIMEOUT } from './csm_dashboard'; | ||
|
|
||
| When(`a user click inside url search field`, () => { | ||
shahzad31 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| // wait for all loading to finish | ||
| cy.get('kbnLoadingIndicator').should('not.be.visible'); | ||
| cy.get('.euiStat__title-isLoading').should('not.be.visible'); | ||
| cy.get('span[data-cy=csmUrlFilter]', DEFAULT_TIMEOUT).within(() => { | ||
| cy.get('input.euiFieldSearch').click(); | ||
| }); | ||
| }); | ||
|
|
||
| Then(`it display top pages in the suggestion popover`, () => { | ||
shahzad31 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| cy.get('kbnLoadingIndicator').should('not.be.visible'); | ||
|
|
||
| cy.get('div.euiPopover__panel-isOpen', DEFAULT_TIMEOUT).within(() => { | ||
| const listOfUrls = cy.get('li.euiSelectableListItem'); | ||
| listOfUrls.should('have.length', 5); | ||
|
|
||
| const actualUrlsText = [ | ||
| 'http://opbeans-node:3000/dashboardPage views: 17Page load duration: 108.734 ms Select', | ||
| 'http://opbeans-node:3000/ordersPage views: 14Page load duration: 71.5895 ms', | ||
| ]; | ||
|
|
||
| cy.get('li.euiSelectableListItem') | ||
| .eq(0) | ||
| .should('have.text', actualUrlsText[0]); | ||
| cy.get('li.euiSelectableListItem') | ||
| .eq(1) | ||
| .should('have.text', actualUrlsText[1]); | ||
| }); | ||
| }); | ||
|
|
||
| When(`a user enters a query in url search field`, () => { | ||
| cy.get('kbnLoadingIndicator').should('not.be.visible'); | ||
|
|
||
| cy.get('[data-cy=csmUrlFilter]').within(() => { | ||
| cy.get('input.euiSelectableTemplateSitewide__search').type('cus'); | ||
| }); | ||
|
|
||
| cy.get('kbnLoadingIndicator').should('not.be.visible'); | ||
| }); | ||
|
|
||
| Then(`it should filter results based on query`, () => { | ||
| cy.get('kbnLoadingIndicator').should('not.be.visible'); | ||
|
|
||
| cy.get('div.euiPopover__panel-isOpen', DEFAULT_TIMEOUT).within(() => { | ||
| const listOfUrls = cy.get('li.euiSelectableListItem'); | ||
| listOfUrls.should('have.length', 1); | ||
|
|
||
| const actualUrlsText = [ | ||
| 'http://opbeans-node:3000/customersPage views: 10Page load duration: 76.3975 ms Select', | ||
| ]; | ||
|
|
||
| cy.get('li.euiSelectableListItem') | ||
| .eq(0) | ||
| .should('have.text', actualUrlsText[0]); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.