[Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue #77366

thomasneirynck · 2020-09-14T15:54:18Z

Summary

Isolates access of mb-property name and mb-proeprty retrieval into single place.

This change has no end-user impact.

#76526 revealed the relationship between how geojson is processed and how the mb-style-rule is generated is not clear.

This simplifies the code, and will make #76526 smaller.

Checklist

Delete any items that are not applicable to this PR.

NA

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-09-14T15:54:20Z

Pinging @elastic/kibana-gis (Team:Geo)

nreese

thanks for moving this out into a separate PR. It makes it a lot easier to view these changes in isolation.

x-pack/plugins/maps/public/classes/styles/vector/properties/dynamic_orientation_property.ts

x-pack/plugins/maps/public/classes/styles/vector/properties/dynamic_style_property.tsx

nreese · 2020-09-15T17:12:35Z

x-pack/plugins/maps/public/classes/styles/vector/properties/dynamic_style_property.tsx

      const fieldName = this.getFieldName();
      const fieldFormatter = this._getFieldFormatter(fieldName);
-      return fieldFormatter ? fieldFormatter(value) : super.formatField(value);
+      return fieldFormatter && value !== null ? fieldFormatter(value) : super.formatField(value);


Why is there a special check for just null? Is this still needed?

x-pack/plugins/maps/public/classes/styles/vector/properties/dynamic_style_property.tsx

…b_codepath

nreese

Thanks for defining a type for RawValue and cleaning up all the types scattered everywhere

LGTM

kibanamachine · 2020-09-15T22:25:24Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: cdbbc08

Build metrics

async chunks size

id	value	diff	baseline
maps	3.3MB	+578.0B	3.3MB

History

💚 Build #74571 succeeded 51b376e
💛 Build #74538 was flaky 0c0eb69
💚 Build #74448 succeeded 31a77f5
💚 Build #74321 succeeded 9b092a6
💚 Build #74266 succeeded 4d45113

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…perty#getMbPropertyValue (elastic#77366)

…s-for-710 * 'master' of github.com:elastic/kibana: (95 commits) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058) [@kbn/utils] Adds missing dependency (elastic#77536) Add the Enterprise Search logo to the Overview search result (elastic#77514) [Logs UI] [Metrics UI] Remove saved object field mappings (elastic#75482) [Security Solution][Exceptions] Exception modal bulk close option only closes alerts generated by same rule (elastic#77402) Adds @kbn/utils package (elastic#76518) Map layout changes (elastic#77132) [Security Solution] [Detections] EQL Rule Creation (elastic#76831) Adding test user to maps tests under documents source folder (elastic#77245) Suppress error logs when clients connect over HTTP instead of HTTPS (elastic#77397) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/phases/warm_phase.tsx

* master: (55 commits) [Grok] Fix missing error message in error toasts (elastic#77499) [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563) [ML] fix type in apply_influencer_filters_action (elastic#77495) [Lens] create reusable component for filters and range aggregation (elastic#77453) fix eslint violations Collapse alert chart previews by default (elastic#77479) [ML] Fixing field caps wrapper endpoint (elastic#77546) showing service maps when filte by environment not defined (elastic#77483) [Lens] Settings panel redesign and separate settings per y axis (elastic#76373) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058) ...

* master: (54 commits) [Grok] Fix missing error message in error toasts (elastic#77499) [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563) [ML] fix type in apply_influencer_filters_action (elastic#77495) [Lens] create reusable component for filters and range aggregation (elastic#77453) fix eslint violations Collapse alert chart previews by default (elastic#77479) [ML] Fixing field caps wrapper endpoint (elastic#77546) showing service maps when filte by environment not defined (elastic#77483) [Lens] Settings panel redesign and separate settings per y axis (elastic#76373) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058) ...

…perty#getMbPropertyValue (#77366) (#77556)

* master: (76 commits) Fixing service maps API test (elastic#77586) [Grok] Fix missing error message in error toasts (elastic#77499) [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563) [ML] fix type in apply_influencer_filters_action (elastic#77495) [Lens] create reusable component for filters and range aggregation (elastic#77453) fix eslint violations Collapse alert chart previews by default (elastic#77479) [ML] Fixing field caps wrapper endpoint (elastic#77546) showing service maps when filte by environment not defined (elastic#77483) [Lens] Settings panel redesign and separate settings per y axis (elastic#76373) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) ...

thomasneirynck added 2 commits September 14, 2020 11:38

init

a7f25d6

remove comment

092d4ef

thomasneirynck added chore Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 14, 2020

thomasneirynck requested a review from a team as a code owner September 14, 2020 15:54

thomasneirynck changed the title ~~[Maps]~~ [Maps] Simplify mb-propertyname and mb-value generation Sep 14, 2020

thomasneirynck added 6 commits September 14, 2020 11:59

use interface-methods

ea382b9

add missing import

78502d4

move getMbPropertyName to style for clarity

f86f671

remove duplicate implementation

e2414bd

simplify

c70e99c

type check

4d45113

thomasneirynck requested a review from nreese September 14, 2020 19:09

thomasneirynck changed the title ~~[Maps] Simplify mb-propertyname and mb-value generation~~ [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue Sep 14, 2020

nreese reviewed Sep 14, 2020

View reviewed changes

feedback

9b092a6

thomasneirynck requested a review from nreese September 14, 2020 22:21

add clarifying comment

31a77f5

thomasneirynck mentioned this pull request Sep 15, 2020

[Maps] Icon rotation should use bearing/azimuth semantics #77496

Closed

nreese reviewed Sep 15, 2020

View reviewed changes

x-pack/plugins/maps/public/classes/styles/vector/properties/dynamic_style_property.tsx Outdated Show resolved Hide resolved

thomasneirynck added 2 commits September 15, 2020 11:44

align types

c5ec78c

ts fixes

0c0eb69

thomasneirynck requested a review from nreese September 15, 2020 16:46

nreese reviewed Sep 15, 2020

View reviewed changes

x-pack/plugins/maps/public/classes/styles/vector/properties/dynamic_style_property.tsx Outdated Show resolved Hide resolved

reuse type

51b376e

isolate type

d570f9a

thomasneirynck requested a review from nreese September 15, 2020 20:31

Merge branch 'master' of github.com:elastic/kibana into chore/reuse_m…

cdbbc08

…b_codepath

nreese approved these changes Sep 15, 2020

View reviewed changes

thomasneirynck merged commit 8b001dc into elastic:master Sep 15, 2020

thomasneirynck mentioned this pull request Sep 15, 2020

[7.x] [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (#77366) #77556

Merged

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Sep 15, 2020

[Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStylePro…

f0783c3

…perty#getMbPropertyValue (elastic#77366)

thomasneirynck added a commit that referenced this pull request Sep 16, 2020

[Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStylePro…

0a715bc

…perty#getMbPropertyValue (#77366) (#77556)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue #77366

[Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue #77366

Uh oh!

thomasneirynck commented Sep 14, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Sep 14, 2020

Uh oh!

nreese left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nreese Sep 15, 2020

Uh oh!

Uh oh!

nreese left a comment

Uh oh!

kibanamachine commented Sep 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue #77366

[Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue #77366

Uh oh!

Conversation

thomasneirynck commented Sep 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Sep 14, 2020

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nreese Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Sep 15, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thomasneirynck commented Sep 14, 2020 •

edited

Loading