[Functional] Fixes cloud failures on TSVB markdown #77158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
changed the title
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
stratoula
changed the title
stratoula
added
test-cloud
failed-test
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
|
Pinging @elastic/kibana-test-triage (failed-test) |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Sep 15, 2020
* [TSVB] Remove the char by char typing on markodown * revert * Add the markdown to be computed immediately and give some time to compute it * Add retry to locate TSVB tabs
stratoula
added a commit
that referenced
this pull request
Sep 15, 2020
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Sep 30, 2020
* [TSVB] Remove the char by char typing on markodown * revert * Add the markdown to be computed immediately and give some time to compute it * Add retry to locate TSVB tabs
stratoula
added a commit
that referenced
this pull request
Sep 30, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #76840. Adds a retry to function which locates the TSVB tabs.
Closes #76450
Closes #76186
All the markdown tests that have to do with entering a markdown and wait to be computed fail on Cloud. This was caused because the markdown was typed char by char but the
PageObjects.visChart.waitForVisualizationRenderingStabilized()was computed and returned true before the typing had ended.I have followed a simpler approach. I type the markdown to be computed immediately and then give some time in order to be computed. I have tested on cloud and it seems to not fail, same happens for the regular tet runner.
https://internal-ci.elastic.co/job/elastic+estf-cloud-kibana-flaky-test-runner/121/ - 10times
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/832/ 100 times
Checklist