[Enterprise Search] Update WS Overview logic to use new config data #77122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test added for app_logic will never happen but hey, 100 is 100. Also added test to recent_activity for 100% coverage
scottybollinger
added
Feature:Plugins
release_note:skip
cee-chen
approved these changes
Sep 10, 2020
Contributor
cee-chen
left a comment
cee-chen
left a comment
There was a problem hiding this comment.
Woohoo, looks great! 🎉 Love the new tests as well!
Contributor
|
Ha, well our codeowners has definitely kicked in :) Tagging @yakhinvadim for a ✅ on this - feel free to skim if you like, I've already tested and reviewed :) |
yakhinvadim
reviewed
Sep 10, 2020
x-pack/plugins/enterprise_search/public/applications/workplace_search/app_logic.ts
Outdated
Show resolved
Hide resolved
TIL this is a thing
yakhinvadim
approved these changes
Sep 10, 2020
Contributor
yakhinvadim
left a comment
yakhinvadim
left a comment
There was a problem hiding this comment.
LGTM, just 1 non-blocking comment:
| const { | ||
| isFederatedAuth, | ||
| organization: { name, defaultOrgName }, | ||
| account: { isCurated, canCreateInvitations }, |
Contributor
There was a problem hiding this comment.
I know this is a tech update PR, so it's not a blocker in any way.
@scottybollinger Do you know if we still need these values or are they legacy and we can remove them (maybe in future PRs)?
Contributor
Author
There was a problem hiding this comment.
I don't know for sure but I am taking a note to find out. Thanks!
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
scottybollinger
added a commit
to scottybollinger/kibana
that referenced
this pull request
Sep 10, 2020
…lastic#77122) * Update AppLogic to use new data structure * Update components to use AppLogic * Remove unused props from logic file * Fix failing tests * Add tests to get 100% converage The test added for app_logic will never happen but hey, 100 is 100. Also added test to recent_activity for 100% coverage * Use non-null assertion operator in logic file TIL this is a thing * Remove test for undefined
scottybollinger
added a commit
that referenced
this pull request
Sep 10, 2020
…77122) (#77240) * Update AppLogic to use new data structure * Update components to use AppLogic * Remove unused props from logic file * Fix failing tests * Add tests to get 100% converage The test added for app_logic will never happen but hey, 100 is 100. Also added test to recent_activity for 100% coverage * Use non-null assertion operator in logic file TIL this is a thing * Remove test for undefined
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 14, 2020
…s-for-710 * 'master' of github.com:elastic/kibana: (65 commits) Separate url forwarding logic and legacy services (elastic#76892) Bump yargs-parser to v13.1.2+ (elastic#77009) [Ingest Manager] Shared Fleet agent policy action (elastic#76013) [Search] Re-add support for aborting when a connection is closed (elastic#76470) [Search] Remove long-running query pop-up (elastic#75385) [Monitoring] Fix UI error when alerting is not available (elastic#77179) do not log plugin id format warning in dist mode (elastic#77134) [ML] Improving client side error handling (elastic#76743) [Alerting][Connectors] Refactor IBM Resilient: Generic Implementation (phase one) (elastic#74357) [Docs] some basic searchsource api docs (elastic#77038) add cGroupOverrides to the legacy config (elastic#77180) Change saved object bulkUpdate to work across multiple namespaces (elastic#75478) [Security Solution][Resolver] Replace Selectable popover with badges (elastic#76997) Removing ml-state index from archive (elastic#77143) [Security Solution] Add unit tests for histograms (elastic#77081) [Lens] Filters aggregation (elastic#75635) [Enterprise Search] Update WS Overview logic to use new config data (elastic#77122) Cleanup type output before building new types (elastic#77211) [Security Solution] Use safe type in resolver backend (elastic#76969) Use proper lodash syntax (elastic#77105) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/node_allocation.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses the newly added config data (#76970) instead of the temporarily augmented server data send from the overview endpoint for the Kibana MVP
Checklist
Delete any items that are not applicable to this PR.
For maintainers