Skip to content

Upgrade EUI to v28.4.0 #77098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 16, 2020
Merged

Upgrade EUI to v28.4.0 #77098

merged 14 commits into from
Sep 16, 2020

Conversation

@thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Sep 9, 2020 •
edited
Loading

Summary

[email protected] ⏩ [email protected]

  • Smaller footprint with removal of docgen info and outdated browsers polyfills
  • New icons
  • Bugfixes for data grids and tables

28.4.0

  • Added loading icon to EuiComboBox input when isLoading is true (#4015)
  • Changed value prop in EuiExpression to not required (#4014)
  • Added fold and unfold glyphs to EuiIcon (#3994)

Bug fixes

  • Fix incorrect euiCodeBlockNameColor variable usage for .hljs-name in SCSS (#3991)
  • Fixed bug in EuiAccordion where the arrowDisplay="right" is ignored when extraAction is configured (#3971)

Theme: Amsterdam

  • Updated form control styles to use a uniform border-radius (#3741)

28.3.1

Bug fixes

  • Fixed bug in EuiComboBox where the input was dropping to the next line when a EuiBadge had a very long text (#3968)
  • Fixed type mismatch between EuiSelectable options extended via EuiSelectableOption and internal option types (#3983)
  • Fixed EuiButton CSS for RTL languages by using margin-inline-[pos] instead of margin-[pos] (#3974)
  • Fixed server-side rendering of EuiBreadcrumbs and EuiCollapsibleNav (#3970)

28.3.0

  • Adjusted coloring of EuiSideNav to be more consistent across open states (#3926)
  • Added build-specific babel configurations for docs and tests (#3911)
  • Updated browserslist configuration to remove IE accommodations (#3911)
  • Removed docgenInfo from non-docs production builds (#3911)
  • Added regressionJob, outlierDetectionJob and classificationJob icons to Machine Learning icon set, updated others. (#3931)
  • Added operator field to EuiSearchBar's field_value_selection filter configuration (#3922)

Bug fixes

  • Fixed bug in EuiBasicTable not fully expanding tall rows (height > 1000px) (#3855)
  • Fixed bug in EuiDataGrid which sometimes prevented header cells from being focusabled (#3943)
  • Fixed bug in EuiFieldSearch where a default value would not include the clear button (#3958)
  • Fixed focus fighting bug when EuiDataGrid cell content manages its own popover (#3951)
  • Fixed valueText getting cut off in EuiProgress (#3948)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 9, 2020
@thompsongl thompsongl marked this pull request as ready for review September 9, 2020 22:57
@thompsongl thompsongl requested review from a team as code owners September 9, 2020 22:57
cauemarcondes
cauemarcondes approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM

@botelastic botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Sep 10, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 10, 2020

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 10, 2020

Pinging @elastic/uptime (Team:uptime)

nreese
nreese approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maps changes LGTM
code review

shahzad31
shahzad31 approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM !!

poffdeluxe
poffdeluxe approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas changes lgtm

@tylersmalley tylersmalley mentioned this pull request Sep 15, 2020
Merged
@cauemarcondes cauemarcondes mentioned this pull request Sep 15, 2020
Merged
tylersmalley
tylersmalley approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops change to ui-shared-deps looks good.

mattkime
mattkime approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app arch changes lgtm

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 16, 2020

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
maps 3.3MB -40.0B 3.3MB
securitySolution 10.1MB -70.0B 10.1MB
total -110.0B

page load bundle size

id value diff baseline
data 1.5MB -426.0B 1.5MB
visTypeTimeseries 279.7KB -954.0B 280.7KB
total -1.3KB

distributable file count

id value diff baseline
default 45938 +30 45908
oss 27754 +26 27728
total +56

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thompsongl thompsongl merged commit e5b302e into elastic:master Sep 16, 2020
@thompsongl thompsongl mentioned this pull request Sep 16, 2020
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Sep 16, 2020
@thompsongl
Upgrade EUI to v28.4.0 (elastic#77098)
b3c079c 
* eui to 28.4.0

* euiselectableoption fixes

* src snapshot updates

* x-pack snapshot updates

* htmlidgenerator mock

* merge resolution

* clean up

* snapshot update

* prevent api changes
thompsongl added a commit that referenced this pull request Sep 17, 2020
@thompsongl @elasticmachine
Upgrade EUI to v28.4.0 (#77098) (#77659)
d3999c4 
* eui to 28.4.0

* euiselectableoption fixes

* src snapshot updates

* x-pack snapshot updates

* htmlidgenerator mock

* merge resolution

* clean up

* snapshot update

* prevent api changes

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattkime mattkime mattkime approved these changes

@nreese nreese nreese approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@cauemarcondes cauemarcondes cauemarcondes approved these changes

+3 more reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@mshustov mshustov mshustov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.