Skip to content

[Monitoring] Prevent edit/create for Stack Monitoring alerts in Alerts Management #77097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2020
Merged

[Monitoring] Prevent edit/create for Stack Monitoring alerts in Alerts Management #77097

merged 1 commit into from
Sep 10, 2020

Conversation

@chrisronline
Copy link
Contributor

@chrisronline chrisronline commented Sep 9, 2020

Resolves #75414

This prevents the creation and editing of Stack Monitoring-specific alerts in the Alerts Management UI since the creation creates a broken UX. The alerting team will follow up in a future version with support for editing but not creation and at that point, we can revert this.

@chrisronline chrisronline requested review from a team and igoristic September 9, 2020 18:19
@chrisronline chrisronline self-assigned this Sep 9, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 9, 2020

Pinging @elastic/stack-monitoring (Team:Monitoring)

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 9, 2020

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
monitoring 298.1KB -2.0B 298.1KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

igoristic
igoristic approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chrisronline chrisronline merged commit 0207f82 into elastic:master Sep 10, 2020
This was referenced Sep 10, 2020
Merged
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Sep 10, 2020
@chrisronline
Prevent editing/creation of these in the alerts management UI (elasti…
6a7ecbf 
…c#77097)
@chrisronline chrisronline deleted the monitoring/alerts_edit branch September 10, 2020 17:19
chrisronline added a commit that referenced this pull request Sep 10, 2020
@chrisronline
Prevent editing/creation of these in the alerts management UI (#77097) (
a0b65e6 
#77207)
chrisronline added a commit that referenced this pull request Sep 10, 2020
@chrisronline
Prevent editing/creation of these in the alerts management UI (#77097) (
9e60f95 
#77208)
@chrisronline
Copy link
Contributor Author

chrisronline commented Sep 10, 2020

Backport:

7.x: a0b65e6
7.9: 9e60f95

@YulNaumenko YulNaumenko mentioned this pull request Sep 10, 2020
Closed
@chrisronline chrisronline mentioned this pull request Dec 14, 2020
Closed
23 tasks
@chrisronline chrisronline mentioned this pull request Mar 1, 2021
Closed
24 tasks
@simianhacker simianhacker mentioned this pull request Apr 29, 2021
Closed
24 tasks
@neptunian neptunian mentioned this pull request Jul 6, 2021
Closed
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igoristic igoristic igoristic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chrisronline chrisronline

Labels

release_note:fix review Team:Monitoring Stack Monitoring team v7.9.2 v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CPU Usage alert condition page is blank

4 participants

@chrisronline @elasticmachine @kibanamachine @igoristic