[Security Solution] Remove filterQueryDraft in favor of SearchBar internal draft state #76833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykkopycinski
added
v8.0.0
release_note:skip
patrykkopycinski
changed the title
…query-bar # Conflicts: # x-pack/plugins/security_solution/public/common/components/query_bar/index.test.tsx # x-pack/plugins/security_solution/public/detections/components/alerts_table/actions.test.tsx # x-pack/plugins/security_solution/public/timelines/components/timeline/header/index.tsx # x-pack/plugins/security_solution/public/timelines/components/timeline/search_or_filter/index.tsx # x-pack/plugins/security_solution/public/timelines/components/timeline/search_or_filter/pick_events.tsx # x-pack/plugins/security_solution/public/timelines/components/timeline/search_or_filter/search_or_filter.tsx # x-pack/plugins/security_solution/public/timelines/components/timeline/timeline.tsx # x-pack/plugins/security_solution/public/timelines/store/timeline/helpers.ts # x-pack/plugins/security_solution/public/timelines/store/timeline/model.ts # x-pack/plugins/security_solution/public/timelines/store/timeline/reducer.test.ts
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
patrykkopycinski
added
bug
patrykkopycinski
removed
the
bug
…query-bar # Conflicts: # x-pack/plugins/security_solution/public/timelines/components/timeline/query_bar/index.test.tsx # x-pack/plugins/security_solution/public/timelines/components/timeline/query_bar/index.tsx
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
MindyRS
added
the
Team: SecuritySolution
Contributor
Author
|
Implemented in #83378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we were adding
QueryBarto the Timeline there was nodraftstate inSearchBar, so we had to create our own implementation of that. As we have it available already inSearchBarhttps://github.com/elastic/kibana/blob/master/src/plugins/data/public/ui/search_bar/search_bar.tsx#L154
there is no need to maintain the custom one, so this PR removes the logic from
https://github.com/elastic/kibana/pull/76833/files#diff-21f7cc5af76326207d231aa24c766e21L62
as well as from the redux store
https://github.com/elastic/kibana/pull/76833/files#diff-257fe3901ca369e1edcaea6720307addL193
Also took advantage of that refactor and migrated
StatefulSearchOrFiltertoSearchOrFilterwith hooks.Checklist