[Security Solution] Updates rules table tooling#76719
Merged
dplumlee merged 12 commits intoelastic:masterfrom Sep 10, 2020
Merged
[Security Solution] Updates rules table tooling#76719dplumlee merged 12 commits intoelastic:masterfrom
dplumlee merged 12 commits intoelastic:masterfrom
Conversation
dplumlee
force-pushed
the
rules-table-enhancements
branch
from
fe37c50 to
5f34783
Compare
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
dplumlee
force-pushed
the
rules-table-enhancements
branch
from
824de28 to
747c45c
Compare
rylnd
approved these changes
Sep 9, 2020
Contributor
rylnd
left a comment
rylnd
left a comment
There was a problem hiding this comment.
These are great UX improvements, thank you!
I had a few nits about naming/refactoring, take or leave them. I also saw a UI bug when only one tag fits in the column, but I believe that was pre-existing:
LGTM!
| sort_field: filterOptions.sortField, | ||
| sort_field: | ||
| filterOptions.sortField === 'name' | ||
| ? `${filterOptions.sortField}.keyword` |
Contributor
There was a problem hiding this comment.
This could maybe be a separate function encapsulating this mapping, e.g. getFieldNameForSortField
| [filterOptions.sortOrder] | ||
| (): SortingType => ({ | ||
| sort: { | ||
| field: filterOptions.sortField as RulesSortingFields, |
Contributor
There was a problem hiding this comment.
Can we narrow the type of FilterOptions['sortField'] instead of a type assertion here?
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
dplumlee
added a commit
that referenced
this pull request
Sep 11, 2020
MindyRS
added
the
Team: SecuritySolution
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses:
ORinstead of anANDupdated_byandversioncolumnnameandupdated_atcolumnScreenshots
Sort by rule name
Sort by last updated
Filter is now an OR
Tags filter search
Checklist
Delete any items that are not applicable to this PR.
For maintainers