Skip to content

Conversation

@cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Sep 1, 2020

Backports the following commits to 7.x:

* Update Home catalogue icons to use new 28.0 EUI app icons

* Fix App Search engine icons in dark mode

- Convert to React SVG element in order to be able to inherit correct fill in dark mode
- Fix vertical centering (taking advantage of SVG centering for us)
- Move icons directly to the engines overview component instead of having to reach upwards to a shared assets folder for them

* [Cleanup] Move Setup Guide images

- to be nested within their own component views that use them, instead of having to grab them upwards from a shared assets folder
@cee-chen cee-chen added the backport This PR is a backport of another PR label Sep 1, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
enterpriseSearch 203 -2 205

async chunks size

id value diff baseline
enterpriseSearch 357.8KB -334.0B 358.1KB

page load bundle size

id value diff baseline
enterpriseSearch 19.8KB -2.8KB 22.6KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit 07daf4a into elastic:7.x Sep 2, 2020
@cee-chen cee-chen deleted the backport/7.x/pr-76430 branch September 4, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants