[7.x] Use platform history (#74328) #76287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: cauemarcondes <[email protected]>
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Sep 1, 2020
* Replace `useLocation` and our `LocationContext` with `useLocation` from React Router. We can do this since we're now using the platform history, added in elastic#76287. * Pass in `RouteComponentProps` where appropriate to routes to use `history` and `location`. This is in the service of elastic#51963, but doesn't do anything with `useUrlParams` or any of the other changes specified in that issue.
smith
added a commit
that referenced
this pull request
Sep 15, 2020
* [APM] Remove useLocation and some minor route improvements * Replace `useLocation` and our `LocationContext` with `useLocation` from React Router. We can do this since we're now using the platform history, added in #76287. * Pass in `RouteComponentProps` where appropriate to routes to use `history` and `location`. This is in the service of #51963, but doesn't do anything with `useUrlParams` or any of the other changes specified in that issue.
smith
added a commit
to smith/kibana
that referenced
this pull request
Sep 15, 2020
…6343) * [APM] Remove useLocation and some minor route improvements * Replace `useLocation` and our `LocationContext` with `useLocation` from React Router. We can do this since we're now using the platform history, added in elastic#76287. * Pass in `RouteComponentProps` where appropriate to routes to use `history` and `location`. This is in the service of elastic#51963, but doesn't do anything with `useUrlParams` or any of the other changes specified in that issue.
smith
added a commit
that referenced
this pull request
Sep 15, 2020
…77476) * [APM] Remove useLocation and some minor route improvements * Replace `useLocation` and our `LocationContext` with `useLocation` from React Router. We can do this since we're now using the platform history, added in #76287. * Pass in `RouteComponentProps` where appropriate to routes to use `history` and `location`. This is in the service of #51963, but doesn't do anything with `useUrlParams` or any of the other changes specified in that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: