[Security Solution] Refactor FirstLastSeenHost to use Search Strategy #76252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
XavierM
reviewed
Aug 31, 2020
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ |
Contributor
There was a problem hiding this comment.
nit -> you are already in the folder of hosts, so we do know that first_last_seen is for a host. Do you agree?
XavierM
approved these changes
Aug 31, 2020
Contributor
XavierM
left a comment
XavierM
left a comment
There was a problem hiding this comment.
Make sense to me, re-organizing the factory queries to a dedicated folder is nice ❤️ .
2 tasks
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Aug 31, 2020
patrykkopycinski
added a commit
that referenced
this pull request
Aug 31, 2020
1 task
MindyRS
added
the
Team: SecuritySolution
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor FirstLastSeenHost to use Search Strategy
Checklist