Skip to content

Conversation

@spalger
Copy link
Contributor

@spalger spalger commented Jul 1, 2016

No description provided.

@elasticdog
Copy link
Contributor

test this please

1 similar comment
@elasticdog
Copy link
Contributor

test this please

@elasticdog
Copy link
Contributor

test this please

1 similar comment
@elasticdog
Copy link
Contributor

test this please

@spalger
Copy link
Contributor Author

spalger commented Jul 1, 2016

jenkins, test this

@spalger
Copy link
Contributor Author

spalger commented Jul 1, 2016

test this please

@spalger
Copy link
Contributor Author

spalger commented Jul 1, 2016

@elasticdog is it a pain to add the previous "jenkins, test this" trigger?

@elasticdog
Copy link
Contributor

@spalger we can change the global trigger phrases to whatever we want...by default, this is what the plugin expects:
screen shot 2016-07-01 at 4 29 43 pm

@spalger
Copy link
Contributor Author

spalger commented Jul 5, 2016

I think that changing the test phase to this would do the trick:

.*(?:jenkins\W+)?test\W+this(?:\W+please)?.*

image

@elasticdog
Copy link
Contributor

test this please

@elasticdog
Copy link
Contributor

test this please ... we've reverted to using a per-job status context setting as it appears there are upstream bugs with the GitHub Pull Request Builder Jenkins plugin that cause problems when trying to set the context at a global-level

@elasticdog
Copy link
Contributor

jenkins, test this

@elasticdog
Copy link
Contributor

good to close this out?

@spalger spalger closed this Jul 7, 2016
@spalger spalger deleted the test/newCi branch October 18, 2019 17:38
cee-chen added a commit that referenced this pull request Mar 26, 2024
`v93.4.0` ⏩ `v93.5.1`

---

## [`v93.5.1`](https://github.com/elastic/eui/releases/v93.5.1)

**Bug fixes**

- Fixed unvirtualized `EuiSelectable`s to not cause Jest/jsdom errors on
active option change ([#7618](elastic/eui#7618))

## [`v93.5.0`](https://github.com/elastic/eui/releases/v93.5.0)

- `EuiHeaderLinks` now accepts a `children` render function that will be
passed a `closeMobilePopover` callback, allowing consumers to close the
mobile popover by its content
([#7603](elastic/eui#7603))
- Updated `EuiSelectable` to support scrolling list containers when
`listProps.isVirtualization` is set to `false`
([#7609](elastic/eui#7609))

**Bug fixes**

- Fixed `EuiIconTip`'s default `aria-label` text to be i18n tokenizable
([#7606](elastic/eui#7606))
- Fixed `EuiTextArea`'s CSS box model to no longer render a few extra
pixels of strut height
([#7607](elastic/eui#7607))

**Dependency updates**

- Updated `@types/refractor` to v3.4.0
([#7590](elastic/eui#7590))
- Updated `@types/lodash` to v4.14.202
([#7591](elastic/eui#7591))
- Removed `@types/resize-observer-browser` dependency. `ResizeObserver`
types should already be baked in to Typescript as of 4.2+
([#7592](elastic/eui#7592))
- Updated `classnames` to v2.5.1
([#7593](elastic/eui#7593))
- Updated `@types/numeral` to v2.0.5
([#7594](elastic/eui#7594))
- Updated `@types/react-window` to 1.8.8
([#7597](elastic/eui#7597))
- Updated `prop-types` to v15.18.1
([#7602](elastic/eui#7602))
- Removed `prop-types` as a peer dependency, per package recommendation
([#7602](elastic/eui#7602))

**Accessibility**

- `EuiIcons` no longer apply `aria-hidden` to empty icons, as long as a
valid title or label is provided to the icon. In particular, this is
intended to improve the accessibility of loading `EuiIconTip`s.
([#7606](elastic/eui#7606))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants