Skip to content

[7.x] Duplicate title warning wording (#75908) #76037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomThomson merged 1 commit into from
Aug 26, 2020
Merged

[7.x] Duplicate title warning wording (#75908) #76037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions src/plugins/saved_objects/public/save_modal/saved_object_save_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,8 @@ export class SavedObjectSaveModal extends React.Component<Props, SaveModalState>
title={
<FormattedMessage
id="savedObjects.saveModal.duplicateTitleLabel"
defaultMessage="A {objectType} with the title '{title}' already exists"
values={{ objectType: this.props.objectType, title: this.state.title }}
defaultMessage="This {objectType} already exists"
values={{ objectType: this.props.objectType }}
/>
}
color="warning"
Expand All @@ -292,18 +292,9 @@ export class SavedObjectSaveModal extends React.Component<Props, SaveModalState>
<p>
<FormattedMessage
id="savedObjects.saveModal.duplicateTitleDescription"
defaultMessage="Clicking {confirmSaveLabel} will save the {objectType} with this duplicate title."
defaultMessage="Saving '{title}' creates a duplicate title."
values={{
objectType: this.props.objectType,
confirmSaveLabel: (
<strong>
{this.props.confirmButtonLabel
? this.props.confirmButtonLabel
: i18n.translate('savedObjects.saveModal.saveButtonLabel', {
defaultMessage: 'Save',
})}
</strong>
),
title: this.props.title,
}}
/>
</p>
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2910,8 +2910,6 @@
"savedObjects.saveDuplicateRejectedDescription": "重複ファイルの保存確認が拒否されました",
"savedObjects.saveModal.cancelButtonLabel": "キャンセル",
"savedObjects.saveModal.descriptionLabel": "説明",
"savedObjects.saveModal.duplicateTitleDescription": "{confirmSaveLabel} をクリックすると {objectType} がこの重複したタイトルで保存されます。",
"savedObjects.saveModal.duplicateTitleLabel": "「{title}」というタイトルの {objectType} が既に存在します",
"savedObjects.saveModal.saveAsNewLabel": "新しい {objectType} として保存",
"savedObjects.saveModal.saveButtonLabel": "保存",
"savedObjects.saveModal.saveTitle": "{objectType} を保存",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2911,8 +2911,6 @@
"savedObjects.saveDuplicateRejectedDescription": "已拒绝使用重复标题保存确认",
"savedObjects.saveModal.cancelButtonLabel": "取消",
"savedObjects.saveModal.descriptionLabel": "描述",
"savedObjects.saveModal.duplicateTitleDescription": "单击“{confirmSaveLabel}”将会使用此重复标题保存 {objectType}。",
"savedObjects.saveModal.duplicateTitleLabel": "具有标题“{title}”的 {objectType} 已存在",
"savedObjects.saveModal.saveAsNewLabel": "另存为新的 {objectType}",
"savedObjects.saveModal.saveButtonLabel": "保存",
"savedObjects.saveModal.saveTitle": "保存 {objectType}",
Expand Down