[Enterprise Search] Adds app logic file to Workplace Search#76009
Merged
scottybollinger merged 6 commits intoelastic:masterfrom Aug 26, 2020
Merged
[Enterprise Search] Adds app logic file to Workplace Search#76009scottybollinger merged 6 commits intoelastic:masterfrom
scottybollinger merged 6 commits intoelastic:masterfrom
Conversation
Adds the easier-to-read ComponentConfigured and ComponentUnconfigured FCs with a ternary in the root compoenent
scottybollinger
added
Feature:Plugins
release_note:skip
scottybollinger
commented
Aug 26, 2020
|
|
||
| expect(wrapper.find(ErrorState).exists()).toBe(true); | ||
| expect(wrapper.find(Overview)).toHaveLength(0); | ||
| expect(wrapper.find(ErrorState)).toHaveLength(2); |
Contributor
Author
There was a problem hiding this comment.
The hidden routes, with navigation, also have an ErrorState
This allows for breaking apart the app-specific data and also having an interface to extend in the app_logic file
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
distributable file count
To update your PR or re-run it, just comment with: |
cee-chen
approved these changes
Aug 26, 2020
Contributor
cee-chen
left a comment
cee-chen
left a comment
There was a problem hiding this comment.
🎉 Looks great! Thanks for the super granular PR!
| export const WorkplaceSearch: React.FC<IInitialAppData> = () => { | ||
| export const WorkplaceSearch: React.FC<IInitialAppData> = (props) => { | ||
| const { config } = useContext(KibanaContext) as IKibanaContext; | ||
| return !config.host ? <WorkplaceSearchUnconfigured /> : <WorkplaceSearchConfigured {...props} />; |
Contributor
There was a problem hiding this comment.
🎉 Glad you liked this pattern I used in App Search!
Comment on lines
+30
to
+31
| const { hasInitialized } = useValues(AppLogic) as IAppValues; | ||
| const { initializeAppData } = useActions(AppLogic) as IAppActions; |
Contributor
There was a problem hiding this comment.
Reminder to self: I should update App Search's IAppLogicValues/Actions types to remove the Logic
scottybollinger
added a commit
that referenced
this pull request
Aug 26, 2020
…76040) * Add new Workplace Search initial data properties * Add app logic * Refactor index to match App Search Adds the easier-to-read ComponentConfigured and ComponentUnconfigured FCs with a ternary in the root compoenent * Remove ‘Logic’ from interface names * Extract initial data from WS into interface This allows for breaking apart the app-specific data and also having an interface to extend in the app_logic file * Destructuring FTW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an app_logic file to Workplace Search. It also introduces 2 new server properties, canCreateInvitations and isFederatedAuth. Finally, a refactor is done on the main index component
Checklist
Delete any items that are not applicable to this PR.
For maintainers