Skip to content

[APM] Prevent imports of public in server code #75979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 28, 2020
Merged

[APM] Prevent imports of public in server code #75979

merged 5 commits into from
Aug 28, 2020

Conversation

@cauemarcondes
Copy link
Contributor

closes #67210

@cauemarcondes cauemarcondes requested a review from a team as a code owner August 26, 2020 13:47
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Aug 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 26, 2020
cauemarcondes
cauemarcondes commented Aug 26, 2020
View reviewed changes
x-pack/plugins/apm/public/services/rest/createCallApmApi.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/apm-ui We still have a lot of this to remove from the public directory, it might take some time to fix all since most of them are types which is automatically inferred.

@tylersmalley
Copy link
Contributor

Thanks so much for this! Mind also removing the exception to the no-restricted-paths rule in eslint as part of this PR? https://github.com/elastic/kibana/blob/master/.eslintrc.js#L301

sorenlouv
sorenlouv approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cauemarcondes !

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

distributable file count

id value diff baseline
total 53128 +2 53126

History

  • 💚 Build #70837 succeeded 68427e972c84ef26df0a0ad5d36676b1bd43dd23
  • 💔 Build #70773 failed f7b33e826c439a5078f1971fe4a75e7a19276614
  • 💔 Build #70767 failed ed506603f0f081a5ff54e7dcf74ea08eb414fd77
  • 💔 Build #70530 failed 84ba4db90ffca37c8b77b02fd68c296f0c4bf511
  • 💔 Build #70500 failed a5b0b37fcbd7e2b6063f7926b39f3678d9fcf420

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 712c4bd into elastic:master Aug 28, 2020
@cauemarcondes cauemarcondes deleted the apm-fix-imports branch August 28, 2020 10:43
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 31, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/data-tier…
174a82d 
…s-for-710

* 'master' of github.com:elastic/kibana: (43 commits)
  [APM] Chart units don't update when toggling the chart legends (elastic#74931)
  [ILM] Add support for frozen phase in UI (elastic#75968)
  Hides advanced json for count metric (elastic#74636)
  add client-side feature usage API (elastic#75486)
  [Maps] add drilldown support map embeddable (elastic#75598)
  [Enterprise Search] Request handler refactors/enhancements + update existing routes to use shared handler (elastic#76106)
  [Resolver] model `location.search` in redux (elastic#76140)
  [APM] Prevent imports of public in server code (elastic#75979)
  fix eslint issue
  skip flaky suite (elastic#76223)
  [APM] Transaction duration anomaly alerting integration (elastic#75719)
  [Transforms] Avoid using "Are you sure" (elastic#75932)
  [Security Solution][Exceptions] - Fix bug of alerts not updating after closure from exceptions modal (elastic#76145)
  [plugin-helpers] improve 3rd party KP plugin support (elastic#75019)
  [docs/getting-started] link to yarn v1 specifically (elastic#76169)
  [Security_Solution][Resolver] Resolver loading and error state (elastic#75600)
  Fixes App Search documentation links (elastic#76133)
  Fix alerts unable to create / update when the name has trailing whitepace(s) (elastic#76079)
  [Resolver] Fix useSelector usage (elastic#76129)
  [Enterprise Search] Migrate util and components from ent-search (elastic#76051)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/data_tier_allocation/node_allocation.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/services/policies/types.ts
#	x-pack/plugins/index_lifecycle_management/public/application/services/policies/warm_phase.ts
@cauemarcondes cauemarcondes mentioned this pull request Aug 31, 2020
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Aug 31, 2020
@cauemarcondes
[APM] Prevent imports of public in server code (elastic#75979)
7fd98d8 
* renaming test file

* removing eslint rule

* restructuring observability types

* refactoring fetchOptions type
cauemarcondes added a commit that referenced this pull request Aug 31, 2020
@cauemarcondes
[APM] Prevent imports of public in server code (#75979) (#76271)
6f622d9 
* renaming test file

* removing eslint rule

* restructuring observability types

* refactoring fetchOptions type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[APM] Prevent imports of public in server code

5 participants

@cauemarcondes @elasticmachine @tylersmalley @kibanamachine @sorenlouv