[ML] Remove encoding for scheduled events labels #75973
Merged
darnautov merged 4 commits intoelastic:masterfrom Aug 27, 2020
Merged
[ML] Remove encoding for scheduled events labels #75973darnautov merged 4 commits intoelastic:masterfrom
darnautov merged 4 commits intoelastic:masterfrom
Conversation
darnautov
added
release_note:fix
:ml
Feature:Anomaly Detection
Contributor
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Aug 26, 2020
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested with a job on the special_characters data set and LGTM
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
This was referenced Aug 27, 2020
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Aug 27, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Aug 27, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
darnautov
added a commit
that referenced
this pull request
Aug 27, 2020
darnautov
added a commit
that referenced
this pull request
Aug 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #74938
HTML encoding is not needed for tooltip content. For some reason, it was applied for Anomaly explorer charts. Since we updated
mlEscapefunction to utilizeheencoding lib with enabledencodeEverythingoption, space symbols also got replaced with HTML character reference&x20;.