using test_user with minimum privileges for canvas functional ui tests#75917
Merged
rashmivkulkarni merged 8 commits intoelastic:masterfrom Aug 27, 2020
Merged
using test_user with minimum privileges for canvas functional ui tests#75917rashmivkulkarni merged 8 commits intoelastic:masterfrom
rashmivkulkarni merged 8 commits intoelastic:masterfrom
Conversation
rashmivkulkarni
added
Team:Presentation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
LeeDr
suggested changes
Aug 26, 2020
poffdeluxe
reviewed
Aug 26, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
bhavyarm
approved these changes
Aug 26, 2020
Contributor
bhavyarm
left a comment
bhavyarm
left a comment
There was a problem hiding this comment.
LGTM. Ran them in my local
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Aug 27, 2020
elastic#75917) * incorporating test_user wth specific roles for the canvas functional ui tests * additional checks - removed comments * changes to incorporate code comments * lint check * incorporate code reviews Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced Aug 27, 2020
rashmivkulkarni
added a commit
that referenced
this pull request
Aug 27, 2020
#75917) (#76056) * incorporating test_user wth specific roles for the canvas functional ui tests * additional checks - removed comments * changes to incorporate code comments * lint check * incorporate code reviews Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meta issue: #60815
Summary
This PR replaces elastic superuser with
test_userwith minimum privileges assigned to thetest_user.New role created:
global_canvas_readChecklist