Skip to content

Duplicate title warning wording#75908

Merged
ThomThomson merged 10 commits intoelastic:masterfrom
ThomThomson:duplicateTitleWording
Aug 26, 2020
Merged

Duplicate title warning wording#75908
ThomThomson merged 10 commits intoelastic:masterfrom
ThomThomson:duplicateTitleWording

Conversation

@ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Aug 25, 2020

Summary

Closes #75665

Implements a small wording change for the duplicate save object title warning.

Screen Shot 2020-08-25 at 2 00 48 PM

@gchaps it's important to note that this changes the wording for most saved object types:

Screen Shot 2020-08-25 at 2 00 15 PM

Screen Shot 2020-08-25 at 2 01 34 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ThomThomson ThomThomson added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 25, 2020
@ThomThomson ThomThomson requested a review from a team August 25, 2020 17:43
@ThomThomson ThomThomson requested a review from a team as a code owner August 25, 2020 17:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Aug 25, 2020
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM

@ThomThomson ThomThomson force-pushed the duplicateTitleWording branch from 50fe6ab to 36e1b54 Compare August 26, 2020 15:30
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
savedObjects 237.0KB -357.0B 237.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit fd39f09 into elastic:master Aug 26, 2020
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Aug 26, 2020
Changed wording on duplicate title warning.
ThomThomson added a commit that referenced this pull request Aug 26, 2020
Changed wording on duplicate title warning.
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Sep 8, 2020
@ThomThomson ThomThomson mentioned this pull request Sep 8, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit text in Save book modal

6 participants