Skip to content

[ML] Adding authorization header to DFA job update request#75899

Merged
jgowdyelastic merged 1 commit intoelastic:masterfrom
jgowdyelastic:adding-auth-headers-to-dfa-job-update
Aug 26, 2020
Merged

[ML] Adding authorization header to DFA job update request#75899
jgowdyelastic merged 1 commit intoelastic:masterfrom
jgowdyelastic:adding-auth-headers-to-dfa-job-update

Conversation

@jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Aug 25, 2020

Authorization headers should be sent as part of the DFA update request.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic self-assigned this Aug 26, 2020
@jgowdyelastic jgowdyelastic added :ml bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features v7.10.0 v7.9.1 v8.0.0 review labels Aug 26, 2020
@jgowdyelastic jgowdyelastic marked this pull request as ready for review August 26, 2020 16:12
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner August 26, 2020 16:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out editing and then starting a DFA job. LGTM.

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@jgowdyelastic jgowdyelastic merged commit 61550b7 into elastic:master Aug 26, 2020
@jgowdyelastic jgowdyelastic deleted the adding-auth-headers-to-dfa-job-update branch August 26, 2020 19:08
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Aug 26, 2020
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Aug 26, 2020
…5899)

# Conflicts:
#	x-pack/plugins/ml/server/routes/data_frame_analytics.ts
jgowdyelastic added a commit that referenced this pull request Aug 27, 2020
…76020)

# Conflicts:
#	x-pack/plugins/ml/server/routes/data_frame_analytics.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features :ml release_note:fix review v7.9.1 v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants