[Discover] Migrate discover.html Angular template to React#75784
Merged
kertal merged 40 commits intoelastic:masterfrom Sep 17, 2020
Merged
[Discover] Migrate discover.html Angular template to React#75784kertal merged 40 commits intoelastic:masterfrom
kertal merged 40 commits intoelastic:masterfrom
Conversation
…-discover-migrate-discover-html
…-discover-migrate-discover-html
kertal
commented
Sep 4, 2020
src/plugins/discover/public/application/components/discover_legacy.tsx
Outdated
Show resolved
Hide resolved
kertal
added
v7.10.0
v8.0.0
Team:Visualizations
Contributor
|
@kertal Is this ready to be reviewed again? |
…thub.com:kertal/kibana into kertal-2020-08-24-discover-migrate-discover-html
kertal
commented
Sep 14, 2020
src/plugins/discover/public/application/angular/directives/fixed_scroll.js
Show resolved
Hide resolved
Member
Author
@flash1293 yes, if Jenkins goes green 🌲 🍏 💚 |
flash1293
approved these changes
Sep 15, 2020
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Tested in Chrome and Firefox and didn't notice any issues. Looks good to me once the aria-expanded I commented on is fixed
cchaos
suggested changes
Sep 15, 2020
src/plugins/discover/public/application/components/discover_legacy.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/angular/directives/fixed_scroll.js
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/components/discover_legacy.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/components/discover_legacy.tsx
Outdated
Show resolved
Hide resolved
kertal
commented
Sep 16, 2020
cchaos
approved these changes
Sep 16, 2020
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
There's still a few seemingly arbitrary pixel values in the SASS, but I'll 👍 for now to unblock progress.
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Sep 17, 2020
…5784) Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
kertal
added a commit
that referenced
this pull request
Sep 17, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the Angular template
discover.html, converts it intoDiscoverLegacy.tsx, a React component. Discover's doc table is still in Angular, so this is also converted into a React ComponentDocTableLegacy, that's a wrapper for an Angular directive. So we're basically turn the table. Before, it was React in Angular, now it's Angular in React. This enables us to continue deangularization (controller, embeddable, router) without being blocked by the one indomitable gallic village of Angular in a React occupied plugin.Checklist
Delete any items that are not applicable to this PR.