IndexPattern class - no longer use getConfig or uiSettingsValues

[mattkime]

Summary

• IndexPattern class no longer uses getConfig or uiSettingsValues dependencies. It now takes shortDotsEnable (boolean) and metaFields (string[]) as arguments - these were formerly provided by uiSettings

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

Dev docs

IndexPattern class no longer uses getConfig or uiSettingsValues dependencies. It now takes shortDotsEnable (boolean) and metaFields (string[]) as arguments - these were formerly provided by uiSettings

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[mattkime]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: c34dc70

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
data	543	+1	542

page load bundle size

id	value	diff	baseline
data	1.4MB	+2.3KB	1.4MB

History

• 💚 Build #69880 succeeded 2a27e86

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[ppisljar]

code LGTM, but i am wondering if this does have some functional changes ?

before we would use getConfig to read the config value at the time we needed it. now we read the config value once when we create the index pattern instance and reuse it later when using the index pattern. Could this lead to any differences in behaviour where a setting would be changed from the time we create index pattern till we use the method on it that uses the config ?

i am assuming no, since the only way to change the setting is to navigate to management. Navigating from there to anywhere in kibana we will recreate the index pattern instances. We need to make sure we don't put index pattern instances to any global state. If we would need to make index pattern available globally we should share the spec rather than the instance.

maybe this is worth putting into a comment (jsdocs for index pattern class)

[mattkime]

Navigating from there to anywhere in kibana we will recreate the index pattern instances.

This is correct. Yes, its worth documenting.