[Core UI] Home Page Solution Cards Fix#75670
Merged
cqliu1 merged 3 commits intoelastic:elastic-home-pagefrom Aug 24, 2020
Merged
[Core UI] Home Page Solution Cards Fix#75670cqliu1 merged 3 commits intoelastic:elastic-home-pagefrom
cqliu1 merged 3 commits intoelastic:elastic-home-pagefrom
Conversation
Contributor
|
Pinging @elastic/kibana-core-ui (Team:Core UI) |
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
Contributor
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
To update your PR or re-run it, just comment with: |
ryankeairns
approved these changes
Aug 21, 2020
Contributor
|
Chatted with Henry on Slack, he stated that he liked what we chose. He is on PTO, so we can move ahead and consider this his approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hey, @cqliu1! Here's my fix for the solution cards' flexbox issue since applying the wrapping
aelements (thanks again for changing that). Whenever you have a moment, take a peek and let me know if you have any questions/suggestions. Changes include:aelement.aelement.Parent Issue: #70571