Add support for decorating and handling 429 errors with the saved objects client #75664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
Team:Core
4 tasks
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
approved these changes
Aug 21, 2020
Contributor
pgayvallet
left a comment
pgayvallet
left a comment
There was a problem hiding this comment.
LGTM for platform changes
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Aug 24, 2020
…ects client (elastic#75664) * Add support for decorating 429 errors in the saved objects client * Update the docs Co-authored-by: Elastic Machine <[email protected]>
mikecote
added a commit
that referenced
this pull request
Aug 24, 2020
…ects client (#75664) (#75762) * Add support for decorating 429 errors in the saved objects client * Update the docs Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm enhancing the
SavedObjectsErrorHelpersclass anddecorateEsErrorfunction to handle 429 errors.The alerting team is planning to build a feature on top of these errors. This will also remove a dependency on Boom errors for our feature.