Skip to content

remove legacy security plugin #75648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 17, 2020
Merged

remove legacy security plugin #75648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e00b83c
remove legacy security plugin
pgayvallet Aug 21, 2020
0b3075c
Merge remote-tracking branch 'upstream/master' into kbn-XXX-remove-le…
pgayvallet Aug 21, 2020
0f9bac5
remove legacy plugin check
pgayvallet Aug 21, 2020
41221a2
Merge remote-tracking branch 'upstream/master' into kbn-XXX-remove-le…
pgayvallet Aug 24, 2020
4d3ba0d
adapt mocha tests
pgayvallet Aug 24, 2020
0a68671
Merge remote-tracking branch 'upstream/master' into kbn-XXX-remove-le…
pgayvallet Sep 17, 2020
2177028
update CODEOWNERS
pgayvallet Sep 17, 2020
619dc0e
Merge remote-tracking branch 'upstream/master' into kbn-XXX-remove-le…
pgayvallet Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@

# Security
/src/core/server/csp/ @elastic/kibana-security @elastic/kibana-platform
/x-pack/legacy/plugins/security/ @elastic/kibana-security
/x-pack/legacy/plugins/spaces/ @elastic/kibana-security
/x-pack/plugins/spaces/ @elastic/kibana-security
/x-pack/plugins/encrypted_saved_objects/ @elastic/kibana-security
Expand Down Expand Up @@ -287,7 +286,6 @@ x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kib
/src/plugins/dashboard/**/*.scss @elastic/kibana-core-ui-designers
/x-pack/plugins/canvas/**/*.scss @elastic/kibana-core-ui-designers
/src/legacy/core_plugins/kibana/public/home/**/*.scss @elastic/kibana-core-ui-designers
/x-pack/legacy/plugins/security/**/*.scss @elastic/kibana-core-ui-designers
/x-pack/legacy/plugins/spaces/**/*.scss @elastic/kibana-core-ui-designers
/x-pack/plugins/spaces/**/*.scss @elastic/kibana-core-ui-designers
/x-pack/plugins/security/**/*.scss @elastic/kibana-core-ui-designers
Expand All @@ -297,7 +295,7 @@ x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kib
/x-pack/plugins/infra/**/*.scss @elastic/observability-design
/x-pack/plugins/ingest_manager/**/*.scss @elastic/observability-design
/x-pack/plugins/observability/**/*.scss @elastic/observability-design
/x-pack/plugins/monitoring/**/*.scss @elastic/observability-design
/x-pack/plugins/monitoring/**/*.scss @elastic/observability-design

# Ent. Search design
/x-pack/plugins/enterprise_search/**/*.scss @elastic/ent-search-design
Expand Down
3 changes: 1 addition & 2 deletions x-pack/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@
*/

import { xpackMain } from './legacy/plugins/xpack_main';
import { security } from './legacy/plugins/security';
Copy link
Member

@azasypkin azasypkin Sep 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would you mind removing two remaining x-pack/legacy/plugins/security entries from the CODEOWNERS file too?

Copy link
Contributor Author

@pgayvallet pgayvallet Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and... It's gone! 2177028

import { spaces } from './legacy/plugins/spaces';

module.exports = function (kibana) {
return [xpackMain(kibana), spaces(kibana), security(kibana)];
return [xpackMain(kibana), spaces(kibana)];
};
21 changes: 0 additions & 21 deletions x-pack/legacy/plugins/security/index.ts
View file
Open in desktop

This file was deleted.