[build] Produce Docker target consistent with stack#75621
Merged
tylersmalley merged 2 commits intoelastic:masterfrom Aug 24, 2020
Merged
[build] Produce Docker target consistent with stack#75621tylersmalley merged 2 commits intoelastic:masterfrom
tylersmalley merged 2 commits intoelastic:masterfrom
Conversation
The release manager is currently expecting a Docker asset image with the format of `kibana-8.0.0-SNAPSHOT-docker-image.tar.gz`. If this target is not found, it will re-export the image. Making this change to produce the expected filename will remove that duplicated effort. Additionally, the release manager plans to remove this fallback in the future anyways. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added
Feature:Build Packaging
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
tylersmalley
added
the
release_note:skip
Member
Author
|
@elastic/kibana-qa a heads up if you're consuming the Kibana Docker images directly and not through Release Manager. This aligns the output of both. |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Aug 24, 2020
The release manager is currently expecting a Docker asset image with the format of `kibana-8.0.0-SNAPSHOT-docker-image.tar.gz`. If this target is not found, it will re-export the image. Making this change to produce the expected filename will remove that duplicated effort. Additionally, the release manager plans to remove this fallback in the future anyways. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tylersmalley
added a commit
that referenced
this pull request
Aug 25, 2020
The release manager is currently expecting a Docker asset image with the format of `kibana-8.0.0-SNAPSHOT-docker-image.tar.gz`. If this target is not found, it will re-export the image. Making this change to produce the expected filename will remove that duplicated effort. Additionally, the release manager plans to remove this fallback in the future anyways. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release manager is currently expecting a Docker image target with the format of
kibana-8.0.0-SNAPSHOT-docker-image.tar.gz. If this target is not found, it will re-export the image. Making this change to produce the expected filename will remove any duplicated effort. Additionally, the release manager plans to remove this fallback in the future anyway.Changes:
-docker.tar.gzto-docker-image.tar.gzdockerOutputDirtodockerTargetFilenamesince it contains the filename, and not the directory as described.This is not a breaking change since the resulting Docker image target is the same from the release manager.