CSS Modification for Light Themed Pinned Queries #756
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Fixes light theme being unreadable.
Contributor
|
edit Ah, I see, only occurs in pinned queries. Would still probably be better to fix this in the LESS. Or even better would be to remove the style inheritance from the label to the popover. That would fix both the text issue, and the fact that everything in the popover shrinks when the query is pinned. |
Contributor
|
Fixed this in LESS |
edmarmoretti
pushed a commit
to edmarmoretti/kibana-pt-br
that referenced
this pull request
Sep 7, 2025
Ignores `xDomain` prop when using a fallback ordinal scale. fixes elastic#756
edmarmoretti
pushed a commit
to edmarmoretti/kibana-pt-br
that referenced
this pull request
Sep 7, 2025
## [20.0.1](elastic/elastic-charts@v20.0.0...v20.0.1) (2020-07-21) ### Bug Fixes * custom domain error with fallback ordinal scale ([elastic#757](elastic/elastic-charts#757)) ([142c3df](elastic/elastic-charts@142c3df)), closes [elastic#756](elastic/elastic-charts#756)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes Issue 667 (#667) by adding a line of light theme specific css to a pinned label.