cleaning up embeddable types#75560
Merged
ppisljar merged 7 commits intoelastic:masterfrom Aug 25, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
ThomThomson
added
v7.10.0
v8.0.0
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
ppisljar
commented
Aug 21, 2020
|
|
||
| if (context.embeddable) { | ||
| const input = context.embeddable.getInput(); | ||
| const input = context.embeddable.getInput() as Readonly<SearchInput>; |
Contributor
Author
There was a problem hiding this comment.
@ThomThomson why Readonly<SearchInput> ? shouldn't query, filters and range be on embeddableinput directly ?
cc @streamich
Contributor
There was a problem hiding this comment.
They will be, I'll merge that PR that adds query, filters and range onto base embeddable.
Contributor
Author
There was a problem hiding this comment.
please ping here once that is done and i can merge master
# Conflicts: # src/plugins/embeddable/public/lib/embeddables/i_embeddable.ts # x-pack/plugins/discover_enhanced/public/actions/explore_data/explore_data_context_menu_action.ts
ThomThomson
approved these changes
Aug 24, 2020
Contributor
ThomThomson
left a comment
ThomThomson
left a comment
There was a problem hiding this comment.
Changes LGTM! Very excited to get rid of this, and make typings a little stricter.
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Aug 25, 2020
ppisljar
added a commit
that referenced
this pull request
Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
embeddable input had this
[key: string]: unknown;property, which is too loosely typed.a few places need to be cleaned up, mostly related to saved object embeddables and cases where the proper input type was not used.
Checklist
Delete any items that are not applicable to this PR.
For maintainers