adding markdown vis renderer #75532
Merged
adding markdown vis renderer #75532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
Feature:Markdown
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
ppisljar
force-pushed
the
tagcloudRenderer
branch
from
2fd16f5 to
2fe1c64
Compare
flash1293
approved these changes
Aug 20, 2020
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Tested in Firefox, works as expected (viewing visualization in Visualize, in Dashboard and in reporting pdf).
Noticed a typo in the test, if that's fixed this LGTM.
| }); | ||
|
|
||
| it('with params', () => { | ||
| vis.params = { markdown: '### my markdown', font: 15, openLinksInNewTab: true }; |
Contributor
There was a problem hiding this comment.
Shouldn't it be fontSize instead of font? The 15 is not showing up in the snapshot as well.
lukeelmers
approved these changes
Aug 20, 2020
Member
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
Code LGTM, pending 💚 from CI
ppisljar
force-pushed
the
tagcloudRenderer
branch
from
2020b76 to
7c50894
Compare
ppisljar
force-pushed
the
tagcloudRenderer
branch
from
7c50894 to
9cb9396
Compare
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Aug 21, 2020
ppisljar
added a commit
that referenced
this pull request
Aug 21, 2020
thomasneirynck
pushed a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 21, 2020
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adds markdown vis renderer and toExpressionAST function
Checklist
Delete any items that are not applicable to this PR.
For maintainers