Skip to content

Log dependency path info in licenses grunt task.#7527

Merged
cjcenizal merged 1 commit intoelastic:masterfrom
cjcenizal:improvement/licenses-task-log-path
Jun 22, 2016
Merged

Log dependency path info in licenses grunt task.#7527
cjcenizal merged 1 commit intoelastic:masterfrom
cjcenizal:improvement/licenses-task-log-path

Conversation

@cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Jun 21, 2016

Split from #7515

Changes

  • Log dependency path info in licenses grunt task. Now you'll see a path of the parent dependencies when a dependency fails to licenses task, so you can identify the offending root dependency.
  • ES2015ify the licenses task.

How to test

  • Install a version of NPM that causes the license-checker to "not find" a license: npm i npm@2.11.0
  • Run the licenses task: grunt licenses

You should get this warning:

Warning: Non-confirming licenses:
 babel@5.8.38 / chokidar@1.4.3 / fsevents@>=1.0.0 <2.0.0 / node-pre-gyp@0.6.25 / nopt@~3.0.1 / abbrev@1 Use --force to continue.

@cjcenizal cjcenizal force-pushed the improvement/licenses-task-log-path branch 4 times, most recently from c6fad15 to 251eb6d Compare June 21, 2016 19:04
@cjcenizal cjcenizal force-pushed the improvement/licenses-task-log-path branch from 251eb6d to 2c9c595 Compare June 21, 2016 19:06
@spalger
Copy link
Contributor

spalger commented Jun 22, 2016

LGTM

- Now you'll see a path of the parent dependencies when a dependency fails to licenses task, so you can identify the offending root dependency.
- ES2015ify the licenses task.
@cjcenizal cjcenizal force-pushed the improvement/licenses-task-log-path branch from 2c9c595 to 6d6ab4a Compare June 22, 2016 01:56
@cjcenizal cjcenizal merged commit ded0ee0 into elastic:master Jun 22, 2016
@cjcenizal cjcenizal deleted the improvement/licenses-task-log-path branch June 22, 2016 03:06
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
…ask-log-path

Log dependency path info in licenses grunt task.

Former-commit-id: ded0ee0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants