Skip to content

Conversation

@pgayvallet
Copy link
Contributor

Backports the following commits to 7.x:

* move all the legacy codebase to KP plugin

* fix imports

* add empty handler context & rename routes folder

* start migrating routes

* migrate rest of the routes

* migrate adapters

* remove beats from legacy xpack plugin

* use nullable + replace response.custom

* fix wrapRouteWithSecurity, remove incorrect header validation

* remove comment

* updating generated plugin list

* fix typos in doc

* adapt readme too.

* remove old commented routes from route files

* remove eslint disabling

* use camel case for plugin id

* update generated doc

Co-authored-by: Josh Dover <[email protected]>
# Conflicts:
#	x-pack/legacy/plugins/beats_management/server/rest_api/beats/configuration.ts
#	x-pack/legacy/plugins/beats_management/server/rest_api/configurations/upsert.ts
@pgayvallet pgayvallet added the backport This PR is a backport of another PR label Aug 18, 2020
@pgayvallet
Copy link
Contributor Author

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
beats_management - -307 307
beatsManagement 307 +307 -
total -0

async chunks size

id value diff baseline
beats_management - -409.3KB 409.3KB
beatsManagement 409.3KB ⚠️ +409.3KB -
total -4.0B

page load bundle size

id value diff baseline
beats_management - -581.6KB 581.6KB
beatsManagement 581.6KB ⚠️ +581.6KB -
total -8.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 737e3ef into elastic:7.x Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants