[Ingest Pipelines] Processor forms for processors E-J #75046

jloleysens · 2020-08-14T14:40:26Z

Summary

This contribution adds forms for the following processors:

Enrich
Fail
Foreach
GeoIP
Grok
Gsub
HTML strip
Inference
Join
JSON

How to test

Start Kibana with basic license
Go to ingest pipelines plugin in management section
Add a processor for each of the forms listed above (attempt to submit to see which fields are required)
Create the pipeline

Additional Context

Continuation of #72849

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

- Also refactored options to live in scoped objects to avoid overriding type (important fix!) - Have not polished copy or form layout.

- date_index_name - dissect - dot_expander - drop Fields refactored: - Field - Ignore missing

…nes/processor-forms-a-d * 'master' of github.com:elastic/kibana: (26 commits) [Telemetry][API Integration] size_in_bytes to be a number (elastic#74664) [ILM] Convert node details flyout to TS (elastic#73707) [Ingest Node Pipelines] Sentence-case processor names (elastic#74645) Bump angular dependency from 1.7.9 to 1.8.0 (elastic#74482) [ML] Fixing schema for custom rule conditions (elastic#74676) [ML] Refactor in preparation for new es client (elastic#74552) [ML] Adding initial file analysis overrides (elastic#74376) Allow any hostname for chromium proxy bypass (elastic#74693) [ML] ML on Kibana Management: Add ability to pass a group ID filter to job management page (elastic#74533) [Metrics UI] Fix No Data preview pluralization (elastic#74399) [Bug][Security_Solution][Telemetry] Capitalize S in macOS (elastic#74688) Remove karma tests from legacy maps (elastic#74668) [Ingest Manager] stop creating events-* index pattern and placeholder index (elastic#74683) [Enterprise Search] Update the browser/document title on plugin navigation (elastic#74392) [visualizations] Add i18n translation for 'No results found' (elastic#74619) [maps] convert vector style properties to TS (elastic#74553) bump geckodriver binary to 0.27 (elastic#74638) fix: update apm agents to catch abort requests (elastic#74658) [Security Solution] Resolver children pagination (elastic#74603) add memoryStatus to df analytics page and analytics table in management (elastic#74570) ...

- Added help text for all fields - Updated layout so that required fields are always on first - Replaced circle radio group with a select drop down

…nes/processor-forms-a-d * 'master' of github.com:elastic/kibana: (25 commits) [ML] Removing full lodash library imports (elastic#74742) [Search] Server strategy example (elastic#71679) [Reporting] Fix and test for Listing of Reports (elastic#74453) [maps] fix drawing shapes (elastic#74689) [Resolver] Improve simulator. Add more click-through tests and panel tests. (elastic#74601) Deprecate schema-less specs in Vega (elastic#73805) [Security Solution] Rename Administration > Hosts subtab to Endpoints (elastic#74287) Timelion deprecation doc (elastic#74508) [Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (elastic#74736) [Lens] Add styling options for x and y axes on the settings popover (elastic#71829) [Maps] add initial location option that fits to data bounds (elastic#74583) theme function (elastic#73451) [data.ui.query] Write filters to query log from default editor. (elastic#74474) [data.search.SearchSource] Move some SearchSource dependencies to the server. (elastic#74607) [Canvas][tech-debt] Convert renderers (elastic#74134) [security solutions][lists] Adds end to end tests (elastic#74473) pluralized for occurrences vs occurrence (elastic#74564) Update links that pointed to CONTRIBUTING.md (elastic#74757) [Ingest pipelines] Implement tabs in processor flyout (elastic#74469) [Event log] Use Alerts client & Actions client when fetching these types of SOs (elastic#73257) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/field_components/text_editor.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/append.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/bytes.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/circle.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/common_fields/field_name_field.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/common_fields/ignore_missing_field.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/convert.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/csv.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/date.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/date_index_name.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/dissect.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/dot_expander.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/drop.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/index.ts # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/shared.ts

…ce processor form

- Also factored out target_field field to common field (still have to update the all instances) - Built out special logic for handling add_to_root and target_field combo on JSON processor form - Created another serializer, for default boolean -> undefined.

…lizer bug

elasticmachine · 2020-08-14T14:40:28Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

kibanamachine · 2020-08-14T14:57:30Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 0daae40
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Check i18n

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
ingestPipelines	401	+26	375

async chunks size

id	value	diff	baseline
ingestPipelines	674.4KB	+64.4KB	610.0KB

page load bundle size

id	value	diff	baseline
ingestPipelines	32.7KB	+489.0B	32.2KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jloleysens · 2020-08-14T15:21:23Z

Closing, will re-open with clean branch

jloleysens and others added 30 commits July 20, 2020 18:07

First few processors of the first batch

e120f03

- Also refactored options to live in scoped objects to avoid overriding type (important fix!) - Have not polished copy or form layout.

add type to shared imports

71274a3

Refactors for repeated fields and added forms

1621eb8

- date_index_name - dissect - dot_expander - drop Fields refactored: - Field - Ignore missing

Merge branch 'master' into ingest-pipelines/processor-forms-a-d

9691f9e

Merge branch 'master' into ingest-pipelines/processor-forms-a-d

0dad23e

Merge branch 'master' into ingest-pipelines/processor-forms-a-d

9952f9b

Merge branch 'master' into ingest-pipelines/processor-forms-a-d

1a52d64

Fix broken imports and some other small refactors

8160f85

added text editor field and updated pattern and if fields

0bcd67a

Large copy improvements and updates and other small refactors

1555486

- Added help text for all fields - Updated layout so that required fields are always on first - Replaced circle radio group with a select drop down

update circle shape type field to select

7059261

Added "long" option for convert type

a529e38

fix path import

106701f

fix types and i18n

5ff03ea

add validation for dot expander fix append value to be a combobox

acc54d7

Merge branch 'master' into ingest-pipelines/processor-forms-a-d

023543b

Added the enrich processor form (big one)

b1a970e

added fail processor form

afe633f

Added foreach processor form

f94c045

Added geoip processor form and refactored some deserialization

9e83a95

added grok processor form and updated comments and some i18n ids

960747c

updated existing gsub processor form to be in line with other forms

5c40bf8

added html_strip processor form

3f3c45f

refactored some serialize and deserialize functions and added inferen…

2fa58df

…ce processor form

fix copy-pasta mistake in inference form and add join processor form

4e2b33b

Added JSON processor field

9933916

- Also factored out target_field field to common field (still have to update the all instances) - Built out special logic for handling add_to_root and target_field combo on JSON processor form - Created another serializer, for default boolean -> undefined.

remove unused variable

daed879

Refactor to use new shared target_field component, and fix JSON seria…

0daae40

…lizer bug

jloleysens added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Feature:Ingest Node Pipelines Ingest node pipelines management labels Aug 14, 2020

jloleysens requested a review from alisonelizabeth August 14, 2020 14:40

jloleysens requested a review from a team as a code owner August 14, 2020 14:40

jloleysens closed this Aug 14, 2020

alisonelizabeth mentioned this pull request Sep 4, 2020

[Ingest pipelines] Forms for processors T-U #76710

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Ingest Pipelines] Processor forms for processors E-J #75046

[Ingest Pipelines] Processor forms for processors E-J #75046

Uh oh!

jloleysens commented Aug 14, 2020

Uh oh!

elasticmachine commented Aug 14, 2020

Uh oh!

kibanamachine commented Aug 14, 2020 •

edited

Loading

Uh oh!

jloleysens commented Aug 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Ingest Pipelines] Processor forms for processors E-J #75046

[Ingest Pipelines] Processor forms for processors E-J #75046

Uh oh!

Conversation

jloleysens commented Aug 14, 2020

Summary

How to test

Additional Context

Checklist

Uh oh!

elasticmachine commented Aug 14, 2020

Uh oh!

kibanamachine commented Aug 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Build metrics

@kbn/optimizer bundle module count

async chunks size

page load bundle size

Uh oh!

jloleysens commented Aug 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kibanamachine commented Aug 14, 2020 •

edited

Loading