Skip to content

Switch from Firefox to Chrome#7502

Merged
LeeDr merged 10 commits intoelastic:4.xfrom
LeeDr:chromeMerge7442To4x
Jun 20, 2016
Merged

Switch from Firefox to Chrome#7502
LeeDr merged 10 commits intoelastic:4.xfrom
LeeDr:chromeMerge7442To4x

Conversation

@LeeDr
Copy link

@LeeDr LeeDr commented Jun 17, 2016

Manual backport of PR 7442 switching the browser for functional tests from Firefox to Chrome.
The latest update to Firefox 47 broke selenium and we wanted to switch to Chrome anyway.

@LeeDr
Copy link
Author

LeeDr commented Jun 20, 2016

jenkins, test it

1 similar comment
@LeeDr
Copy link
Author

LeeDr commented Jun 20, 2016

jenkins, test it

@LeeDr LeeDr added the review label Jun 20, 2016
@LeeDr
Copy link
Author

LeeDr commented Jun 20, 2016

Here's the last 4 builds all successful;
Success > Console Output#4​27​5 Jun 20, 2016 8:05 PM PR #7502: ​Switch ​from ​Firefox ​to ​Chrome
Success > Console Output#4​27​4 Jun 20, 2016 7:47 PM PR #7502: ​Switch ​from ​Firefox ​to ​Chrome
Success > Console Output#4​27​2 Jun 20, 2016 7:11 PM PR #7502: ​Switch ​from ​Firefox ​to ​Chrome
Success > Console Output#4​27​1 Jun 20, 2016 6:55 PM PR #7502: ​Switch ​from ​Firefox ​to ​Chrome

@jbudz
Copy link
Contributor

jbudz commented Jun 20, 2016

Tagging #7442

@jbudz
Copy link
Contributor

jbudz commented Jun 20, 2016

LGTM

@cjcenizal
Copy link
Contributor

cjcenizal commented Jun 20, 2016

You might want to ignore the screenshots themselves by adding this to gitignore:

/test/screenshots/failure/*.png
/test/screenshots/session/*.png

Other than that, LGTM!

@LeeDr LeeDr merged commit da702b4 into elastic:4.x Jun 20, 2016
elastic-jasper added a commit that referenced this pull request Jul 21, 2016
@elastic-jasper
Backport PR #7502
065cd11 
---------

**Commit 1:**
Switch from Firefox to Chrome

* Original sha: 677a6c1
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-06-17T22:32:15Z

**Commit 2:**
fix chromedriver.path

* Original sha: 589cb71
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-06-20T14:25:22Z

**Commit 3:**
More selenium cleanup

* Original sha: 056294b
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-06-20T15:23:29Z

**Commit 4:**
Put task intern:dev back in!

* Original sha: b85d919
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-06-20T15:38:18Z

**Commit 5:**
temporary screenshots fix

* Original sha: 8a9178c
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-06-20T16:11:53Z

**Commit 6:**
Add screenshots dir

* Original sha: 929f30c
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-06-20T16:26:07Z

**Commit 7:**
Add getSpinnerDone on clickNewSearch to fix failures

* Original sha: dfacedb
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-06-20T16:54:48Z

**Commit 8:**
Backport screenshots 'session' and 'failure' folders

* Original sha: fe9f34c
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-06-20T18:04:56Z

**Commit 9:**
gitignore *.png in failures and session

* Original sha: 06d70e6
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-06-20T20:53:26Z

**Commit 10:**
Update .gitignore

* Original sha: 603f503
* Authored by Lee Drengenberg <lee.drengenberg@elastic.co> on 2016-06-20T21:21:55Z
* Committed by GitHub <noreply@github.com> on 2016-06-20T21:21:55Z
@elastic-jasper elastic-jasper mentioned this pull request Jul 21, 2016
Merged
epixa added a commit that referenced this pull request Jul 21, 2016
@epixa
Merge pull request #7792 from elastic/jasper/backport/7502/4.5
790202b 
[backport] PR #7502 to 4.5
@LeeDr LeeDr deleted the chromeMerge7442To4x branch May 23, 2017 13:57
cee-chen added a commit that referenced this pull request Feb 20, 2024
@cee-chen
Upgrade EUI to v93.1.1 (#176762)
2680755 
`v93.0.0` ⏩ `v93.1.1`

---

## [`v93.1.1`](https://github.com/elastic/eui/releases/v93.2.0)

**This is a patch release primarily intended for use by Kibana.**

- Added top-level `EuiTreeView.Item` export
([#7526](elastic/eui#7526))

## [`v93.1.0`](https://github.com/elastic/eui/releases/v93.1.0)

- Added `index` glyph to `EuiIcon`
([#7498](elastic/eui#7498))
- Updated `EuiHighlight` to accept an array of `search` strings, which
allows highlighting multiple, separate words within its children. This
new type and behavior *only* works if `highlightAll` is also set to
true. ([#7496](elastic/eui#7496))
- Updated `EuiContextMenu` with a new `panels.items.renderItem`
property, which allows rendering completely custom items next to
standard `EuiContextMenuItem` objects
([#7510](elastic/eui#7510))
- `EuiSuperDatePicker` updates:
- Updated `EuiSuperDatePicker` with a new `refreshIntervalUnits` prop.
Passing this prop allows controlling and overriding the default unit
rounding behavior. ([#7501](elastic/eui#7501))
- Updated `EuiAutoRefresh` and `EuiRefreshInterval` with a new
`intervalUnits` prop. Passing this prop allows controlling and
overriding the default unit rounding behavior.
([#7501](elastic/eui#7501))
- Updated `onRefreshChange` to pass back a new `intervalUnits` key that
contains the current interval unit format (seconds, minutes, or hours).
([#7501](elastic/eui#7501))
- Updated `EuiSuperDatePicker` with a new `canRoundRelativeUnits` prop,
which defaults to true (current behavior). To preserve displaying the
unit that users select for relative time, set this to false.
([#7502](elastic/eui#7502))
- Updated `EuiSuperDatePicker` with a new `refreshMinInterval` prop,
which accepts a minimum number in milliseconds
([#7516](elastic/eui#7516))
- Updated `EuiAutoRefresh` and `EuiRefreshInterval` with a new
`minInterval` prop, which accepts a minimum number in milliseconds
([#7516](elastic/eui#7516))

**Bug fixes**

- Fixed `EuiHighlight` to not parse `search` strings as regexes
([#7496](elastic/eui#7496))
- Fixed `EuiSuperDatePicker` submit bug when used within `<form>`
elements ([#7504](elastic/eui#7504))
- Fixed an `EuiTreeView` bug where `aria-expanded` was being applied to
items without expandable children
([#7513](elastic/eui#7513))

**CSS-in-JS conversions**

- Converted `EuiTreeView` to Emotion. Updates as part of the conversion:
([#7513](elastic/eui#7513))
  - Removed `.euiTreeView__wrapper` div node
  - Enforced consistent `icon` size based on `display` size
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@cee-chen @fkanout
Upgrade EUI to v93.1.1 (elastic#176762)
2b74c27 
`v93.0.0` ⏩ `v93.1.1`

---

## [`v93.1.1`](https://github.com/elastic/eui/releases/v93.2.0)

**This is a patch release primarily intended for use by Kibana.**

- Added top-level `EuiTreeView.Item` export
([elastic#7526](elastic/eui#7526))

## [`v93.1.0`](https://github.com/elastic/eui/releases/v93.1.0)

- Added `index` glyph to `EuiIcon`
([elastic#7498](elastic/eui#7498))
- Updated `EuiHighlight` to accept an array of `search` strings, which
allows highlighting multiple, separate words within its children. This
new type and behavior *only* works if `highlightAll` is also set to
true. ([elastic#7496](elastic/eui#7496))
- Updated `EuiContextMenu` with a new `panels.items.renderItem`
property, which allows rendering completely custom items next to
standard `EuiContextMenuItem` objects
([elastic#7510](elastic/eui#7510))
- `EuiSuperDatePicker` updates:
- Updated `EuiSuperDatePicker` with a new `refreshIntervalUnits` prop.
Passing this prop allows controlling and overriding the default unit
rounding behavior. ([elastic#7501](elastic/eui#7501))
- Updated `EuiAutoRefresh` and `EuiRefreshInterval` with a new
`intervalUnits` prop. Passing this prop allows controlling and
overriding the default unit rounding behavior.
([elastic#7501](elastic/eui#7501))
- Updated `onRefreshChange` to pass back a new `intervalUnits` key that
contains the current interval unit format (seconds, minutes, or hours).
([elastic#7501](elastic/eui#7501))
- Updated `EuiSuperDatePicker` with a new `canRoundRelativeUnits` prop,
which defaults to true (current behavior). To preserve displaying the
unit that users select for relative time, set this to false.
([elastic#7502](elastic/eui#7502))
- Updated `EuiSuperDatePicker` with a new `refreshMinInterval` prop,
which accepts a minimum number in milliseconds
([elastic#7516](elastic/eui#7516))
- Updated `EuiAutoRefresh` and `EuiRefreshInterval` with a new
`minInterval` prop, which accepts a minimum number in milliseconds
([elastic#7516](elastic/eui#7516))

**Bug fixes**

- Fixed `EuiHighlight` to not parse `search` strings as regexes
([elastic#7496](elastic/eui#7496))
- Fixed `EuiSuperDatePicker` submit bug when used within `<form>`
elements ([elastic#7504](elastic/eui#7504))
- Fixed an `EuiTreeView` bug where `aria-expanded` was being applied to
items without expandable children
([elastic#7513](elastic/eui#7513))

**CSS-in-JS conversions**

- Converted `EuiTreeView` to Emotion. Updates as part of the conversion:
([elastic#7513](elastic/eui#7513))
  - Removed `.euiTreeView__wrapper` div node
  - Enforced consistent `icon` size based on `display` size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jbudz jbudz

Labels

review test v4.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LeeDr @jbudz @cjcenizal