[RUM Dashboard] Rum design improvement#74946
Merged
shahzad31 merged 22 commits intoelastic:masterfrom Aug 25, 2020
Merged
Conversation
shahzad31
added
v7.10.0
v8.0.0
release_note:skip
shahzad31
changed the title
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
andrewvc
reviewed
Aug 21, 2020
Contributor
andrewvc
left a comment
andrewvc
left a comment
There was a problem hiding this comment.
The functionality changes here are great, but I'm wondering why there are no test changes. Do we not have coverage here?
Contributor
Author
@andrewvc most of these are small cosmetics changes not covered by tests. We do have some e2e tests but no snapshots tests. |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
smith
approved these changes
Aug 24, 2020
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Aug 25, 2020
* craete new path for client side monitoring * update * update app * fix i18n * remove space * added feature on server * use lazy load * update test * update * remove csm serve file * update test * added design improvements * imrpove design * fix types * rervet conflict screw up * revert Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
shahzad31
added a commit
that referenced
this pull request
Aug 25, 2020
* craete new path for client side monitoring * update * update app * fix i18n * remove space * added feature on server * use lazy load * update test * update * remove csm serve file * update test * added design improvements * imrpove design * fix types * rervet conflict screw up * revert Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #72592
Improve small issues in design
sinstead ofsec(I think this is more consistent with the rest of Kibana