[TSVB] Fixes bug on TopN weird behavior with zero values#74942
Merged
stratoula merged 1 commit intoelastic:masterfrom Aug 14, 2020
Merged
[TSVB] Fixes bug on TopN weird behavior with zero values#74942stratoula merged 1 commit intoelastic:masterfrom
stratoula merged 1 commit intoelastic:masterfrom
Conversation
stratoula
changed the title
stratoula
added
Feature:TSVB
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mbondyra
approved these changes
Aug 14, 2020
Contributor
mbondyra
left a comment
mbondyra
left a comment
There was a problem hiding this comment.
Haven't tested, code looks good to me!
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Aug 14, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 14, 2020
* master: Fix bug on TopN weird behavior with zero values (elastic#74942) [Lens] Fix table sorting bug (elastic#74902) [SECURITY_SOLUTION] Retry on ingest setup (elastic#75000) [file upload] lazy load to reduce page load size (elastic#74967) Drilldowns for TSVB / Vega / Timelion (elastic#74848) [EventLog] Populate alert instances view with event log data (elastic#68437) [UiActions] pass trigger into action execution context (elastic#74363)
stratoula
added a commit
that referenced
this pull request
Aug 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #72604. When the value was zero, the division returned NaN, causing this weird behaviour on TopN.
I changed it to default on 0 when NaN is detected.
Checklist