[functional test][saved objects] update tests for additional copy saved objects to space by LeeDr · Pull Request #74907 · elastic/kibana

LeeDr · 2020-08-12T21:53:03Z

Summary

The saved objects table has some number of "actions" for each type of saved object. If there are 1 or 2 actions they have icons directly on the row. If there are 3 or more actions applicable to the saved object a context menu is shown which opens to show the actions.

"Spaces" and therefore "Copy to space" isn't in OSS builds so that actions menu changes for tests running in CI vs Cloud. So OSS import_objects test has to handle both paths. Fixes: #74432

This PR also fixes an issue in an x-pack test x-pack/test/functional/apps/spaces/copy_saved_objects.ts where it was filtering saved objects for A Dashboard but depending on other tests which had run before it, also found A Pie which broke the test. The fix for this is in x-pack/test/functional/page_objects/copy_saved_objects_to_space_page.ts where, after the filtering, we get the whole table of elements and can explicitly use the actions menu by the saved object title.
await elements[objectName].menuElement?.click();
Fixes: #44575

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
This was checked for cross-browser compatibility

test/functional/apps/management/_import_objects.js

x-pack/test/functional/page_objects/copy_saved_objects_to_space_page.ts

LeeDr · 2020-08-13T23:59:58Z

10 runs of test/functional/apps/management/_import_objects·js on the Cloud flaky test runner all passed. This is the test which previously failed in #74432

elasticmachine · 2020-08-14T01:07:54Z

Pinging @elastic/kibana-platform (Team:Platform)

LeeDr · 2020-08-14T01:08:13Z

@elasticmachine merge upstream

legrego · 2020-08-14T10:00:55Z

test/functional/page_objects/management/saved_objects_page.ts

+    async clickCopyToSpaceByTitle(title: string) {
+      const table = keyBy(await this.getElementsInTable(), 'title');
+      // should we check if table size > 0 and log error if not?
+      if (table[title].menuElement) {
+        log.debug(`we found a context menu element for (${title}) so click it`);
+        await table[title].menuElement?.click();
+        // Wait for context menu to render
+        const menuPanel = await find.byCssSelector('.euiContextMenuPanel');
+        await (
+          await menuPanel.findByTestSubject('savedObjectsTableAction-copy_saved_objects_to_space')
+        ).click();
+      } else {
+        log.debug(
+          `we didn't find a menu element so should be a relastionships element for (${title}) to click`
+        );
+        // or the action elements are on the row without the menu
+        await table[title].copySaveObjectsElement?.click();
+      }
+    }


Are we ok to have x-pack specific test constructs inside an OSS Page Object?

test/functional/page_objects/management/saved_objects_page.ts

dmlemeshko

Code LGTM.

30/30 on flaky test runner https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/776/

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>

kibanamachine · 2020-08-14T17:00:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 041f61b

Build metrics

✅ unchanged

History

💚 Build #68073 succeeded d1c471c
💚 Build #67856 succeeded a84994a
💔 Build #67850 failed 6e37223

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ed objects to space (elastic#74907) Co-authored-by: Larry Gregory <lgregorydev@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…py saved objects to space (#74907) (#75069) Co-authored-by: Larry Gregory <lgregorydev@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…py saved objects to space (#74907) (#75070) Co-authored-by: Larry Gregory <lgregorydev@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (24 commits) [ML] Functional tests - skip regression and classification tests [Ingest Manager] fix removing ingest pipelines from elasticsearch (elastic#75092) move tests for placeholder indices to setup (elastic#75096) [jest] temporarily extend default test timeout (elastic#75118) [cli] remove reference to removed --optimize flag (elastic#75083) skip flaky suite (elastic#75044) Adding /etc/rc.d/init.d/functions to the init script when present to … (elastic#22985) [jenkins] add pipeline for hourly security solution cypress tests (elastic#75087) [Reporting/Flaky Test] Skip test for paging list of reports (elastic#75075) remove .kbn-optimizer-cache upload (elastic#75086) skip flaky suite (elastic#74814) Actions add proxy support (elastic#74289) [ILM] TS conversion of Edit policy components (elastic#74747) [Resolver] simulator tests select elements directly instead of using descendant selectors. (elastic#75058) [Enterprise Search] Add Workplace Search side navigation (elastic#74894) [Security solution] Sourcerer: Kibana index pattern selector for security views (elastic#74706) [Logs UI] Remove apollo deps from log link-to routes (elastic#74502) [Maps] add map configurations to docker list (elastic#75035) [functional test][saved objects] update tests for additional copy saved objects to space (elastic#74907) Make the alerts plugin support generics (elastic#72716) ...

These were unskipped in #74907, but the copy-to-space flyout has changed. Updated the tests to use new test subject selectors, and also updated some of the i18n keys to be more consistent.

LeeDr added 2 commits August 12, 2020 14:30

fixes saved object tests 74432 and 44575

38f6ddd

use getElementsInTable to open saved objects context menu

765d69b

LeeDr added Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.0 v8.0.0 Feature:Saved Objects Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// labels Aug 12, 2020

LeeDr commented Aug 12, 2020

View reviewed changes

test/functional/apps/management/_import_objects.js Outdated Show resolved Hide resolved

LeeDr commented Aug 12, 2020

View reviewed changes

test/functional/apps/management/_import_objects.js Outdated Show resolved Hide resolved

LeeDr commented Aug 12, 2020

View reviewed changes

x-pack/test/functional/page_objects/copy_saved_objects_to_space_page.ts Outdated Show resolved Hide resolved

LeeDr added 2 commits August 12, 2020 20:02

refactor, and force logout in spaces test

6e37223

remove unused

a84994a

LeeDr requested review from dmlemeshko and legrego August 13, 2020 18:57

LeeDr marked this pull request as ready for review August 14, 2020 01:07

Merge branch 'master' into savedObjectsMenu

d1c471c

legrego approved these changes Aug 14, 2020

View reviewed changes

dmlemeshko approved these changes Aug 14, 2020

View reviewed changes

Update test/functional/page_objects/management/saved_objects_page.ts

041f61b

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>

LeeDr merged commit 5627ab3 into elastic:master Aug 14, 2020

LeeDr deleted the savedObjectsMenu branch August 14, 2020 17:20

LeeDr mentioned this pull request Aug 14, 2020

[7.x] [functional test][saved objects] update tests for additional copy saved objects to space (#74907) #75069

Merged

LeeDr mentioned this pull request Aug 14, 2020

[7.9] [functional test][saved objects] update tests for additional copy saved objects to space (#74907) #75070

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[functional test][saved objects] update tests for additional copy saved objects to space#74907

[functional test][saved objects] update tests for additional copy saved objects to space#74907
LeeDr merged 6 commits intoelastic:masterfrom
LeeDr:savedObjectsMenu

LeeDr commented Aug 12, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LeeDr commented Aug 13, 2020

Uh oh!

elasticmachine commented Aug 14, 2020

Uh oh!

LeeDr commented Aug 14, 2020

Uh oh!

legrego Aug 14, 2020

Uh oh!

Uh oh!

dmlemeshko left a comment

Uh oh!

kibanamachine commented Aug 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

LeeDr commented Aug 12, 2020

Summary

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LeeDr commented Aug 13, 2020

Uh oh!

elasticmachine commented Aug 14, 2020

Uh oh!

LeeDr commented Aug 14, 2020

Uh oh!

legrego Aug 14, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dmlemeshko left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Aug 14, 2020

💚 Build Succeeded

Build metrics

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants