[Ingest Pipelines] Use sentence case for mouse tooltip #74847
Merged
jloleysens merged 1 commit intoelastic:masterfrom Aug 12, 2020
Merged
Conversation
jloleysens
added
Team:Kibana Management
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
yuliacech
approved these changes
Aug 12, 2020
Contributor
yuliacech
left a comment
yuliacech
left a comment
There was a problem hiding this comment.
Hi @jloleysens , the change looks good to me! Tested locally and the tooltip was rendered correctly for both a known and a custom processor.
jloleysens
deleted the
ingest-pipelines/fix/use-sentence-case-for-mouse-tooltip
branch
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 12, 2020
jloleysens
added a commit
that referenced
this pull request
Aug 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This contribution adds support for rendering known-processors per their user-friendly defined labels in the mouse tooltip.
How to test
my-processor)Screenshots
Known processor
Unknown processor
