Skip to content

[Security Solution] put back savedObjectId in error message#74775

Merged
angorayc merged 2 commits intoelastic:masterfrom
angorayc:issues/830
Aug 12, 2020
Merged

[Security Solution] put back savedObjectId in error message#74775
angorayc merged 2 commits intoelastic:masterfrom
angorayc:issues/830

Conversation

@angorayc
Copy link
Contributor

Summary

This PR is to fix issue https://github.com/elastic/siem-team/issues/830

How to verify this PR:

  • Preconditions
    Elasticsearch and kibana should be up and running
    Audit beat Data Shipper should be installed and running.
  1. Select 'Security' from kibana Left Navigation bar.
  2. Click on 'Timeline' Tab.
  3. Create new template.
  4. Export the Above Template.
  5. Click on Import Timeline and select above template just saved
  6. SavedObjectId should exist in error message

savedobjectId

@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@angorayc angorayc added the release_note:skip Skip the PR/issue when compiling release notes label Aug 11, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +143.0B 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream


const isImportRulesResponseError = (
error: ImportRulesResponseError | ImportResponseError
): error is ImportRulesResponseError => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very interesting type solution

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angorayc angorayc merged commit be7e21c into elastic:master Aug 12, 2020
angorayc added a commit to angorayc/kibana that referenced this pull request Aug 12, 2020
…74775)

* put back savedObjectId in error message

* fix type error
angorayc added a commit to angorayc/kibana that referenced this pull request Aug 12, 2020
…74775)

* put back savedObjectId in error message

* fix type error
angorayc added a commit that referenced this pull request Aug 12, 2020
…74866)

* put back savedObjectId in error message

* fix type error
angorayc added a commit that referenced this pull request Aug 12, 2020
…74865)

* put back savedObjectId in error message

* fix type error
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.1 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants