[Security Solution] put back savedObjectId in error message#74775
Merged
angorayc merged 2 commits intoelastic:masterfrom Aug 12, 2020
Merged
[Security Solution] put back savedObjectId in error message#74775angorayc merged 2 commits intoelastic:masterfrom
angorayc merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
|
|
||
| const isImportRulesResponseError = ( | ||
| error: ImportRulesResponseError | ImportResponseError | ||
| ): error is ImportRulesResponseError => { |
Contributor
There was a problem hiding this comment.
very interesting type solution
Contributor
Author
There was a problem hiding this comment.
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Aug 12, 2020
…74775) * put back savedObjectId in error message * fix type error
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Aug 12, 2020
…74775) * put back savedObjectId in error message * fix type error
angorayc
added a commit
that referenced
this pull request
Aug 12, 2020
angorayc
added a commit
that referenced
this pull request
Aug 12, 2020
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to fix issue https://github.com/elastic/siem-team/issues/830
How to verify this PR:
Elasticsearch and kibana should be up and running
Audit beat Data Shipper should be installed and running.