[plugin installer] check multiple default paths for config#7440
[plugin installer] check multiple default paths for config#7440jbudz merged 2 commits intoelastic:masterfrom
Conversation
|
jenkins, test it |
src/cli_plugin/install/index.js
Outdated
| ]; | ||
|
|
||
| let defaultPath = paths[0]; | ||
| paths.some(configPath => { |
There was a problem hiding this comment.
Wouldn't using _.find() make more sense than _.some() here? They both iterate through a collection and stop once a condition is met, but... some is used to answer a question about the state of a collection; "Are there some elements in the collection that meet these conditions?" Where find is used to return an element in a collection; "Give me the first element of a collection that meets these conditions"
|
Are we checking multiple paths for kibana.yml to cover both the cases of package installation and archive installation?
Or are we trying to handle an upgrade case without having to move the previous version kibana.yml? |
|
@LeeDr checking multiple paths for package and archive installation. |
|
This seems like it needs to be a blocker since #7308 is merged. Otherwise plugin install will fail on package installs, right? Edit: fixed PR link |
|
If #7308 ends up getting backported, make sure this does as well. |
|
Correct, it'll fail unless |
|
LGTM |
[plugin installer] check multiple default paths for config Former-commit-id: a167253
With #7275 packages install their config to /etc/kibana/kibana.yml by default. This updates the plugin installer to check multiple default paths, and adds the package path to the list.