Skip to content

[Canvas][Docs] Adds var and var_set to expression function reference#74291

Merged
cqliu1 merged 2 commits intoelastic:masterfrom
cqliu1:docs/fn-update
Aug 24, 2020
Merged

[Canvas][Docs] Adds var and var_set to expression function reference#74291
cqliu1 merged 2 commits intoelastic:masterfrom
cqliu1:docs/fn-update

Conversation

@cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Aug 4, 2020

Summary

Related to #66139.

This adds function definition sections for var and var_set.

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials

For maintainers

@cqliu1 cqliu1 added Team:Docs Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v7.10.0 docs v7.9.1 labels Aug 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@cqliu1 cqliu1 requested review from a team, KOTungseth and poffdeluxe August 4, 2020 19:07
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few comments, but otherwise, LGTM!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Updates kibana global context
Updates the Kibana global context.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Kibana global context a noun? Is it supposed to be capitalized?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|Specify name of the variable
|Specify the name of the variable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Updates kibana global context
Updates the Kibana global context.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|Specify name of the variable
|Specify the name of the variable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|Specify value for the variable. If not provided input context will be used
|Specify the value for the variable. When unspecified, the input context is used.

@cqliu1 cqliu1 requested a review from a team as a code owner August 18, 2020 16:49
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Aug 18, 2020
Copy link
Contributor

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM! 🚀

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
expressions 346.7KB +26.0B 346.6KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 restored the docs/fn-update branch June 8, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.9.1 v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants