[Canvas][Docs] Adds var and var_set to expression function reference#74291
Merged
cqliu1 merged 2 commits intoelastic:masterfrom Aug 24, 2020
Merged
[Canvas][Docs] Adds var and var_set to expression function reference#74291cqliu1 merged 2 commits intoelastic:masterfrom
var and var_set to expression function reference#74291cqliu1 merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
Contributor
|
Pinging @elastic/kibana-docs (Team:Docs) |
KOTungseth
approved these changes
Aug 6, 2020
Contributor
KOTungseth
left a comment
There was a problem hiding this comment.
Made a few comments, but otherwise, LGTM!
Contributor
There was a problem hiding this comment.
Suggested change
| Updates kibana global context | |
| Updates the Kibana global context. |
Contributor
There was a problem hiding this comment.
Is Kibana global context a noun? Is it supposed to be capitalized?
Contributor
There was a problem hiding this comment.
Suggested change
| |Specify name of the variable | |
| |Specify the name of the variable. |
Contributor
There was a problem hiding this comment.
Suggested change
| Updates kibana global context | |
| Updates the Kibana global context. |
Contributor
There was a problem hiding this comment.
Suggested change
| |Specify name of the variable | |
| |Specify the name of the variable. |
Contributor
There was a problem hiding this comment.
Suggested change
| |Specify value for the variable. If not provided input context will be used | |
| |Specify the value for the variable. When unspecified, the input context is used. |
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Aug 24, 2020
This was referenced Aug 24, 2020
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Aug 24, 2020
cqliu1
added a commit
that referenced
this pull request
Aug 25, 2020
cqliu1
added a commit
that referenced
this pull request
Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #66139.
This adds function definition sections for
varandvar_set.Checklist
Delete any items that are not applicable to this PR.
For maintainers