Skip to content

[Security Solution] styling for notes' panel #74274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2020
Merged

[Security Solution] styling for notes' panel #74274

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b88d7a
styling for notes' pannel
angorayc Aug 4, 2020
fe0143a
styling
angorayc Aug 4, 2020
cd05b5e
remove additional const
angorayc Aug 4, 2020
f4831e2
styling
angorayc Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions x-pack/plugins/security_solution/public/timelines/components/notes/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ interface Props {
const NotesPanel = styled(EuiPanel)`
height: ${NOTES_PANEL_HEIGHT}px;
width: ${NOTES_PANEL_WIDTH}px;
overflow-y: auto;

& thead {
display: none;
Expand All @@ -43,16 +44,6 @@ const NotesPanel = styled(EuiPanel)`

NotesPanel.displayName = 'NotesPanel';

const InMemoryTable: typeof EuiInMemoryTable & { displayName: string } = styled(
EuiInMemoryTable as React.ComponentType<EuiInMemoryTableProps<Note>>
)`
overflow-x: hidden;
overflow-y: auto;
height: 220px;
` as any; // eslint-disable-line @typescript-eslint/no-explicit-any

InMemoryTable.displayName = 'InMemoryTable';

/** A view for entering and reviewing notes */
export const Notes = React.memo<Props>(
({ associateNote, getNotesByIds, getNewNoteId, noteIds, status, updateNote }) => {
Expand All @@ -76,7 +67,7 @@ export const Notes = React.memo<Props>(
/>
)}
<EuiSpacer size="s" />
<InMemoryTable
<EuiInMemoryTable
data-test-subj="notes-table"
items={getNotesByIds(noteIds)}
columns={columns}
Expand Down