Update to TS v4

package.json

@@ -86,7 +86,7 @@
     "**/@types/chai": "^4.2.11",
     "**/cypress/@types/lodash": "^4.14.159",
     "**/cypress/lodash": "^4.17.20",
-    "**/typescript": "3.9.5",
+    "**/typescript": "4.0.2",
     "**/graphql-toolkit/lodash": "^4.17.15",
     "**/hoist-non-react-statics": "^3.3.2",
     "**/isomorphic-git/**/base64-js": "^1.2.1",
@@ -381,8 +381,8 @@
     "@types/vinyl": "^2.0.4",
     "@types/vinyl-fs": "^2.4.11",
     "@types/zen-observable": "^0.8.0",
-    "@typescript-eslint/eslint-plugin": "^3.7.1",
-    "@typescript-eslint/parser": "^3.7.1",
+    "@typescript-eslint/eslint-plugin": "^3.10.0",
+    "@typescript-eslint/parser": "^3.10.0",
     "angular-mocks": "^1.7.9",
     "archiver": "^3.1.1",
     "axe-core": "^3.4.1",
@@ -473,7 +473,7 @@
     "supertest-as-promised": "^4.0.2",
     "tape": "^4.13.0",
     "tree-kill": "^1.2.2",
-    "typescript": "3.9.5",
+    "typescript": "4.0.2",
     "typings-tester": "^0.3.2",
     "vinyl-fs": "^3.0.3",
     "xml2js": "^0.4.22",

packages/eslint-config-kibana/package.json

@@ -15,8 +15,8 @@
   },
   "homepage": "https://github.com/elastic/kibana/tree/master/packages/eslint-config-kibana",
   "peerDependencies": {
-    "@typescript-eslint/eslint-plugin": "^3.7.1",
-    "@typescript-eslint/parser": "^3.7.1",
+    "@typescript-eslint/eslint-plugin": "^3.10.0",
+    "@typescript-eslint/parser": "^3.10.0s",
     "babel-eslint": "^10.0.3",
     "eslint": "^6.8.0",
     "eslint-plugin-babel": "^5.3.0",

packages/kbn-analytics/package.json

@@ -17,6 +17,6 @@
     "@babel/cli": "^7.10.5",
     "@kbn/dev-utils": "1.0.0",
     "@kbn/babel-preset": "1.0.0",
-    "typescript": "3.9.5"
+    "typescript": "4.0.2"
   }
 }

packages/kbn-config-schema/package.json

@@ -10,7 +10,7 @@
     "kbn:bootstrap": "yarn build"
   },
   "devDependencies": {
-    "typescript": "3.9.5",
+    "typescript": "4.0.2",
     "tsd": "^0.7.4"
   },
   "peerDependencies": {

packages/kbn-dev-utils/package.json

@@ -25,7 +25,7 @@
     "tslib": "^2.0.0"
   },
   "devDependencies": {
-    "typescript": "3.9.5",
+    "typescript": "4.0.2",
     "@kbn/expect": "1.0.0",
     "chance": "1.0.18"
   }

packages/kbn-i18n/package.json

@@ -21,7 +21,7 @@
     "del": "^5.1.0",
     "getopts": "^2.2.4",
     "supports-color": "^7.0.0",
-    "typescript": "3.9.5"
+    "typescript": "4.0.2"
   },
   "dependencies": {
     "intl-format-cache": "^2.1.0",

packages/kbn-monaco/package.json

@@ -20,7 +20,7 @@
     "del": "^5.1.0",
     "raw-loader": "3.1.0",
     "supports-color": "^7.0.0",
-    "typescript": "3.9.5",
+    "typescript": "4.0.2",
     "webpack": "^4.41.5",
     "webpack-cli": "^3.3.10"
   }

packages/kbn-plugin-helpers/package.json

@@ -35,7 +35,7 @@
     "@types/through2": "^2.0.35",
     "@types/through2-map": "^3.0.0",
     "@types/vinyl": "^2.0.4",
-    "typescript": "3.9.5"
+    "typescript": "4.0.2"
   },
   "peerDependencies": {
     "@kbn/babel-preset": "1.0.0"

packages/kbn-pm/dist/index.js

@@ -562,6 +562,7 @@ module.exports = require("path");
  * under the License.
  */
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.ToolingLogCollectingWriter = exports.parseLogLevel = exports.pickLevelFromFlags = exports.ToolingLogTextWriter = exports.ToolingLog = void 0;
 var tooling_log_1 = __webpack_require__(6);
 Object.defineProperty(exports, "ToolingLog", { enumerable: true, get: function () { return tooling_log_1.ToolingLog; } });
 var tooling_log_text_writer_1 = __webpack_require__(110);

packages/kbn-pm/package.json

@@ -59,7 +59,7 @@
     "strip-ansi": "^4.0.0",
     "strong-log-transformer": "^2.1.0",
     "tempy": "^0.3.0",
-    "typescript": "3.9.5",
+    "typescript": "4.0.2",
     "unlazy-loader": "^0.1.3",
     "webpack": "^4.41.5",
     "webpack-cli": "^3.3.10",

packages/kbn-release-notes/package.json

@@ -18,6 +18,6 @@
   },
   "devDependencies": {
     "markdown-it": "^10.0.0",
-    "typescript": "3.9.5"
+    "typescript": "4.0.2"
   }
-}
+}

packages/kbn-telemetry-tools/package.json

@@ -17,6 +17,6 @@
     "normalize-path": "^3.0.0",
     "@types/lodash": "^3.10.1",
     "moment": "^2.24.0",
-    "typescript": "3.9.5"
+    "typescript": "4.0.2"
   }
 }

packages/kbn-telemetry-tools/src/tools/serializer.ts

@@ -137,14 +137,11 @@ export function getDescriptor(node: ts.Node, program: ts.Program): Descriptor |
   }
 
   if (ts.isUnionTypeNode(node)) {
-    const types = node.types.filter((typeNode) => {
-      return (
-        typeNode.kind !== ts.SyntaxKind.NullKeyword &&
-        typeNode.kind !== ts.SyntaxKind.UndefinedKeyword
-      );
-    });
+    const types = node.types.filter(discardNullOrUndefined);
 
-    const kinds = types.map((typeNode) => getDescriptor(typeNode, program));
+    const kinds = types
+      .map((typeNode) => getDescriptor(typeNode, program))
+      .filter(discardNullOrUndefined);
 
     const uniqueKinds = uniq(kinds, 'kind');
 
@@ -167,3 +164,9 @@ export function getDescriptor(node: ts.Node, program: ts.Program): Descriptor |
       throw new Error(`Unknown type ${ts.SyntaxKind[node.kind]}; ${node.getText()}`);
   }
 }
+
+function discardNullOrUndefined(typeNode: ts.TypeNode | Descriptor | DescriptorValue) {
+  return (
+    typeNode.kind !== ts.SyntaxKind.NullKeyword && typeNode.kind !== ts.SyntaxKind.UndefinedKeyword
+  );
+}

src/plugins/advanced_settings/public/management_app/advanced_settings.tsx

@@ -228,7 +228,7 @@ export class AdvancedSettingsComponent extends Component<
 }
 
 export const AdvancedSettings = (props: AdvancedSettingsProps) => {
-  const { query } = useParams();
+  const { query } = useParams<{ query: string }>();
   return (
     <AdvancedSettingsComponent
       queryText={query || ''}

src/plugins/dashboard/common/bwc/types.ts

@@ -53,7 +53,7 @@ interface DashboardAttributes extends SavedObjectAttributes {
 interface DashboardAttributesTo720 extends SavedObjectAttributes {
   panelsJSON: string;
   description: string;
-  uiStateJSON: string;
+  uiStateJSON?: string;
   version: number;
   timeRestore: boolean;
   useMargins?: boolean;

src/plugins/dashboard/public/application/dashboard_app_controller.tsx

@@ -464,6 +464,7 @@ export class DashboardAppController {
                 );
               } else if ('input' in incomingEmbeddable) {
                 const input = incomingEmbeddable.input;
+                // @ts-expect-error
                 delete input.id;
                 const explicitInput = {
                   savedVis: input,

src/plugins/data/common/es_query/kuery/ast/ast.test.ts

@@ -350,12 +350,14 @@ describe('kuery AST API', () => {
       expect(toElasticsearchQuery((null as unknown) as KueryNode, undefined)).toEqual(expected);
 
       const noTypeNode = nodeTypes.function.buildNode('exists', 'foo');
+
+      // @ts-expect-error
       delete noTypeNode.type;
       expect(toElasticsearchQuery(noTypeNode)).toEqual(expected);
 
       const unknownTypeNode = nodeTypes.function.buildNode('exists', 'foo');
 
-      // @ts-ignore
+      // @ts-expect-error
       unknownTypeNode.type = 'notValid';
       expect(toElasticsearchQuery(unknownTypeNode)).toEqual(expected);
     });

src/plugins/kibana_react/public/context/context.test.tsx

@@ -122,7 +122,7 @@ test('<KibanaContextProvider> provider provides default kibana-react context', (
 
 test('<KibanaContextProvider> can set custom services in context', () => {
   const Test: React.FC = () => {
-    const { services } = useKibana();
+    const { services } = useKibana<{ test: string }>();
     expect(services.test).toBe('quux');
     return null;
   };
@@ -137,7 +137,7 @@ test('<KibanaContextProvider> can set custom services in context', () => {
 
 test('nested <KibanaContextProvider> override and merge services', () => {
   const Test: React.FC = () => {
-    const { services } = useKibana();
+    const { services } = useKibana<{ foo: string; bar: string; baz: string }>();
     expect(services.foo).toBe('foo2');
     expect(services.bar).toBe('bar');
     expect(services.baz).toBe('baz3');

src/plugins/kibana_usage_collection/server/collectors/ops_stats/ops_stats_collector.ts

@@ -43,11 +43,13 @@ export function getOpsStatsCollector(
   metrics$.subscribe((_metrics) => {
     const metrics = cloneDeep(_metrics);
     // Ensure we only include the same data that Metricbeat collection would get
+    // @ts-expect-error
     delete metrics.process.pid;
     const responseTimes = {
       average: metrics.response_times.avg_in_millis,
       max: metrics.response_times.max_in_millis,
     };
+    // @ts-expect-error
     delete metrics.requests.statusCodes;
     lastMetrics = {
       ...metrics,

src/plugins/share/public/types.ts

@@ -55,7 +55,7 @@ export interface ShareContext {
  * */
 export interface ShareContextMenuPanelItem extends Omit<EuiContextMenuPanelItemDescriptor, 'name'> {
   name: string; // EUI will accept a `ReactNode` for the `name` prop, but `ShareContentMenu` assumes a `string`.
-  sortOrder: number;
+  sortOrder?: number;
 }
 
 /**

src/plugins/vis_default_editor/public/components/agg_select.tsx

@@ -22,8 +22,9 @@ import React, { useEffect, useCallback, useState } from 'react';
 import { EuiComboBox, EuiComboBoxOptionOption, EuiFormRow, EuiLink, EuiText } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n/react';
-
 import { IAggType, IndexPattern } from 'src/plugins/data/public';
+
+import { DocLinksStart } from '../../../../core/public';
 import { useKibana } from '../../../kibana_react/public';
 import { ComboBoxGroupedOptions } from '../utils';
 import { AGG_TYPE_ACTION_KEYS, AggTypeAction } from './agg_params_state';
@@ -52,7 +53,7 @@ function DefaultEditorAggSelect({
   onChangeAggType,
 }: DefaultEditorAggSelectProps) {
   const [isDirty, setIsDirty] = useState(false);
-  const { services } = useKibana();
+  const { services } = useKibana<{ docLinks: DocLinksStart }>();
   const selectedOptions: ComboBoxGroupedOptions<IAggType> = value
     ? [{ label: value.title, target: value }]
     : [];
@@ -71,6 +72,7 @@ function DefaultEditorAggSelect({
 
   let aggHelpLink: string | undefined;
   if (has(value, 'name')) {
+    // @ts-expect-error
     aggHelpLink = services.docLinks.links.aggs[value.name];
   }
 

src/plugins/vis_default_editor/public/components/controls/date_ranges.tsx

@@ -37,6 +37,7 @@ import { FormattedMessage } from '@kbn/i18n/react';
 import { i18n } from '@kbn/i18n';
 import { isEqual, omit } from 'lodash';
 import { useMount } from 'react-use';
+import { DocLinksStart } from 'src/core/public';
 
 import { useKibana } from '../../../../kibana_react/public';
 import { AggParamEditorProps } from '../agg_param_props';
@@ -67,7 +68,7 @@ function DateRangesParamEditor({
   setValue,
   setValidity,
 }: AggParamEditorProps<DateRangeValues[]>) {
-  const { services } = useKibana();
+  const { services } = useKibana<{ docLinks: DocLinksStart }>();
   const [ranges, setRanges] = useState(() =>
     value.map((range) => ({ ...range, id: generateId() }))
   );

src/plugins/vis_default_editor/public/components/controls/filter.tsx

@@ -21,7 +21,12 @@ import React, { useState } from 'react';
 import { EuiForm, EuiButtonIcon, EuiFieldText, EuiFormRow, EuiSpacer } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 
-import { IAggConfig, Query, QueryStringInput } from '../../../../data/public';
+import {
+  IAggConfig,
+  Query,
+  QueryStringInput,
+  DataPublicPluginStart,
+} from '../../../../data/public';
 import { useKibana } from '../../../../kibana_react/public';
 
 interface FilterRowProps {
@@ -49,7 +54,7 @@ function FilterRow({
   onChangeValue,
   onRemoveFilter,
 }: FilterRowProps) {
-  const { services } = useKibana();
+  const { services } = useKibana<{ data: DataPublicPluginStart; appName: string }>();
   const [showCustomLabel, setShowCustomLabel] = useState(false);
   const filterLabel = i18n.translate('visDefaultEditor.controls.filters.filterLabel', {
     defaultMessage: 'Filter {index}',