Skip to content

[ML] Fixing recognizer wizard create job button #73025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2020
Merged

[ML] Fixing recognizer wizard create job button #73025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff0b494
[ML] Fixing recognizer wizard create job button
jgowdyelastic Jul 23, 2020
0c13694
updating translations
jgowdyelastic Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions x-pack/plugins/ml/public/application/jobs/new_job/recognize/components/job_settings_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,27 +258,19 @@ export const JobSettingsForm: FC<JobSettingsFormProps> = ({
fill
type="submit"
isLoading={saveState === SAVE_STATE.SAVING}
disabled={!validationResult.formValid}
disabled={!validationResult.formValid || saveState === SAVE_STATE.SAVING}
onClick={() => {
onSubmit(formState);
}}
aria-label={i18n.translate('xpack.ml.newJob.recognize.createJobButtonAriaLabel', {
defaultMessage: 'Create job',
})}
>
{saveState === SAVE_STATE.NOT_SAVED && (
<FormattedMessage
id="xpack.ml.newJob.recognize.createJobButtonLabel"
defaultMessage="Create {numberOfJobs, plural, zero {Job} one {Job} other {Jobs}}"
values={{ numberOfJobs: jobs.length }}
/>
)}
{saveState === SAVE_STATE.SAVING && (
<FormattedMessage
id="xpack.ml.newJob.recognize.analysisRunningLabel"
defaultMessage="Analysis running"
/>
)}
<FormattedMessage
id="xpack.ml.newJob.recognize.createJobButtonLabel"
defaultMessage="Create {numberOfJobs, plural, zero {Job} one {Job} other {Jobs}}"
values={{ numberOfJobs: jobs.length }}
/>
</EuiButton>
</EuiTextAlign>
</>
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10239,7 +10239,6 @@
"xpack.ml.newJob.recognize.advancedLabel": "高度な設定",
"xpack.ml.newJob.recognize.advancedSettingsAriaLabel": "高度な設定",
"xpack.ml.newJob.recognize.alreadyExistsLabel": "(既に存在します)",
"xpack.ml.newJob.recognize.analysisRunningLabel": "分析を実行中",
"xpack.ml.newJob.recognize.cancelJobOverrideLabel": "閉じる",
"xpack.ml.newJob.recognize.createJobButtonAriaLabel": "ジョブを作成",
"xpack.ml.newJob.recognize.createJobButtonLabel": "{numberOfJobs, plural, zero {Job} one {Job} other {Jobs}} を作成",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10244,7 +10244,6 @@
"xpack.ml.newJob.recognize.advancedLabel": "高级",
"xpack.ml.newJob.recognize.advancedSettingsAriaLabel": "高级设置",
"xpack.ml.newJob.recognize.alreadyExistsLabel": "（已存在）",
"xpack.ml.newJob.recognize.analysisRunningLabel": "分析正在运行",
"xpack.ml.newJob.recognize.cancelJobOverrideLabel": "关闭",
"xpack.ml.newJob.recognize.createJobButtonAriaLabel": "创建作业",
"xpack.ml.newJob.recognize.createJobButtonLabel": "创建{numberOfJobs, plural, zero {作业} one {Job} other {Jobs}}",
Expand Down