Unskipping DLS/FLS tests #72858
Merged
Unskipping DLS/FLS tests #72858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
added
Team:Security
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
Contributor
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
jportner
approved these changes
Jul 22, 2020
Contributor
jportner
left a comment
jportner
left a comment
There was a problem hiding this comment.
LGTM.
For posterity: did we make any changes in Kibana so that these tests would pass? If so, can we link them to this issue?
Member
Author
Nope, this test failure was due to a regression on the Elasticsearch side, resolved via elastic/elasticsearch#59693 |
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Jul 22, 2020
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Jul 22, 2020
legrego
added a commit
that referenced
this pull request
Jul 22, 2020
legrego
added a commit
that referenced
this pull request
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unskips tests which were failing the ES snapshot promotion.
Tests were skipped due to a regression on the ES side, resolved via elastic/elasticsearch#59693
Resolves #70818
Resolves #70880