Skip to content

[Security solution] [Timeline] Bug fix for "Collapse event" button #72552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 22, 2020
Merged

[Security solution] [Timeline] Bug fix for "Collapse event" button #72552

merged 4 commits into from
Jul 22, 2020

Conversation

@stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Jul 20, 2020 •
edited
Loading

Summary

Addresses a bug with the X style collapse button by changing the design to a link at the bottom of the event details.

Screen Shot 2020-07-21 at 10 17 52 AM

@stephmilovic stephmilovic added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 20, 2020
@stephmilovic stephmilovic self-assigned this Jul 20, 2020
@stephmilovic stephmilovic marked this pull request as ready for review July 21, 2020 17:47
@stephmilovic stephmilovic requested review from a team as code owners July 21, 2020 17:47
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 21, 2020

Pinging @elastic/siem (Team:SIEM)

andrew-goldstein
andrew-goldstein approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephmilovic for the fix and @marrasherrier for the suggested design change 🙏 🙏

  • Tested locally

LGTM 🚀

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 22, 2020

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-xpack-agent / Closes and opens alerts.Alerts Closing alerts Closes and opens alerts

Link to Jenkins

Stack Trace

AssertionError: Timed out retrying: Expected to find element: `[data-test-subj="loading-alerts-panel"]`, but never found it.
    at ensureExistence (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:137673:32)
    at Object.ensureElExistence (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:137691:12)
    at ensureExistence (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:127867:23)
    at onFailFn (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:127905:9)
    at tryCatcher (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:9065:23)
    at Promise._settlePromiseFromHandler (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:7000:31)
    at Promise._settlePromise (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:7057:18)
    at Promise._settlePromise0 (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:7102:10)
    at Promise._settlePromises (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:7178:18)
    at _drainQueueStep (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:3772:12)
    at _drainQueue (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:3765:9)
    at Async.../../node_modules/bluebird/js/release/async.js.Async._drainQueues (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:3781:5)
    at Async.drainQueues (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:3651:14)

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB -594.0B 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit f6bc61f into elastic:master Jul 22, 2020
@stephmilovic stephmilovic mentioned this pull request Jul 22, 2020
Merged
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Jul 22, 2020
@stephmilovic
[Security solution] [Timeline] Bug fix for "Collapse event" button (e…
96902f4 
…lastic#72552)
@stephmilovic stephmilovic mentioned this pull request Jul 22, 2020
Merged
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Jul 22, 2020
@stephmilovic
[Security solution] [Timeline] Bug fix for "Collapse event" button (e…
b1575d5 
…lastic#72552)
@stephmilovic stephmilovic deleted the fix-close-button-tl branch July 22, 2020 15:43
stephmilovic added a commit that referenced this pull request Jul 23, 2020
@stephmilovic
[Security solution] [Timeline] Bug fix for "Collapse event" button (#…
5f8e953 
…72552) (#72857)
stephmilovic added a commit that referenced this pull request Jul 23, 2020
@stephmilovic @elasticmachine
[Security solution] [Timeline] Bug fix for "Collapse event" button (#…
ebe72ff 
…72552) (#72856)

Co-authored-by: Elastic Machine <[email protected]>
@MindyRS MindyRS added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Sep 23, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 23, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

1 similar comment
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 23, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees

@stephmilovic stephmilovic

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stephmilovic @elasticmachine @kibanamachine @andrew-goldstein @MindyRS