Ts 4 project references and incremental builds

docs/developer/plugin/development-plugin-resources.asciidoc

@@ -53,7 +53,7 @@ To enable TypeScript support, create a `tsconfig.json` file at the root of your
 -----------
 {
   // extend Kibana's tsconfig, or use your own settings
-  "extends": "../../kibana/tsconfig.json",
+  "extends": "../../kibana/tsconfig.base.json",
 
   // tell the TypeScript compiler where to find your source files
   "include": [

examples/alerting_example/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target"
   },

examples/bfetch_explorer/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

examples/dashboard_embeddable_examples/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

examples/developer_examples/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

examples/embeddable_examples/tsconfig.json

@@ -1,8 +1,10 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
+    "composite": true,
     "outDir": "./target",
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "jsx": "react",
   },
   "include": [
     "index.ts",
@@ -12,5 +14,6 @@
     "server/**/*.ts",
     "../../typings/**/*"
   ],
-  "exclude": []
+  "exclude": [],
+  "references": [{"path": "../../tsconfig.src.json"}]
 }

examples/embeddable_explorer/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

examples/state_containers_examples/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

examples/ui_action_examples/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

examples/ui_actions_explorer/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

examples/url_generators_examples/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

examples/url_generators_explorer/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

package.json

@@ -88,7 +88,7 @@
     "**/@types/chai": "^4.2.11",
     "**/cypress/@types/lodash": "^4.14.155",
     "**/cypress/lodash": "^4.15.19",
-    "**/typescript": "3.9.5",
+    "**/typescript": "4.0.0-beta",
     "**/graphql-toolkit/lodash": "^4.17.15",
     "**/hoist-non-react-statics": "^3.3.2",
     "**/isomorphic-git/**/base64-js": "^1.2.1",
@@ -503,7 +503,7 @@
     "supertest-as-promised": "^4.0.2",
     "tape": "^4.13.0",
     "tree-kill": "^1.2.2",
-    "typescript": "3.9.5",
+    "typescript": "4.0.0-beta",
     "typings-tester": "^0.3.2",
     "vinyl-fs": "^3.0.3",
     "xml2js": "^0.4.22",

packages/elastic-datemath/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "declaration": true,
     "outDir": "./target"

packages/kbn-analytics/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "declaration": true,
     "declarationDir": "./target/types",

packages/kbn-config-schema/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "declaration": true,
     "declarationDir": "./target/types",

packages/kbn-dev-utils/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "target",
     "target": "ES2019",

packages/kbn-es/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "include": [
     "src/**/*.ts"
   ]

packages/kbn-expect/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "include": [
     "expect.js.d.ts"
   ]

packages/kbn-i18n/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "include": [
     "src/**/*.ts",
     "src/**/*.tsx",

packages/kbn-interpreter/tsconfig.json

@@ -1,4 +1,4 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "include": ["index.d.ts", "src/**/*.d.ts"]
 }

packages/kbn-monaco/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "declaration": true,

packages/kbn-optimizer/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "include": [
     "index.d.ts",
     "src/**/*"

packages/kbn-plugin-generator/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "include": ["**/*", "index.js.d.ts"],
   "exclude": ["sao_template/template/*"]
 }

packages/kbn-plugin-helpers/README.md

@@ -80,7 +80,7 @@ Plugin code can be written in [TypeScript](http://www.typescriptlang.org/) if de
 ```js
 {
   // extend Kibana's tsconfig, or use your own settings
-  "extends": "../../kibana/tsconfig.json",
+  "extends": "../../kibana/tsconfig.base.json",
 
   // tell the TypeScript compiler where to find your source files
   "include": [

packages/kbn-plugin-helpers/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "target",
     "declaration": true,

packages/kbn-pm/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "include": [
     "./src/**/*.ts",
     "./dist/*.d.ts",

packages/kbn-release-notes/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "declaration": true,

packages/kbn-telemetry-tools/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "include": [
     "src/**/*",
   ]

packages/kbn-test-subj-selector/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "include": [
     "index.d.ts"
   ],

packages/kbn-test/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "include": [
     "types/**/*",
     "src/**/*",

packages/kbn-ui-shared-deps/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "include": [
     "index.d.ts",
     "theme.ts"

packages/kbn-utility-types/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "declaration": true,
     "declarationDir": "./target",

src/dev/typescript/project.ts

@@ -53,13 +53,14 @@ export class Project {
   public name: string;
   public config: any;
   public disableTypeCheck: boolean;
+  public disableNoEmit: boolean;
 
   private readonly include: IMinimatch[];
   private readonly exclude: IMinimatch[];
 
   constructor(
     public tsConfigPath: string,
-    options: { name?: string; disableTypeCheck?: boolean } = {}
+    options: { name?: string; disableTypeCheck?: boolean; disableNoEmit?: boolean } = {}
   ) {
     this.config = parseTsConfig(tsConfigPath);
 
@@ -69,16 +70,17 @@ export class Project {
       exclude?: string[];
     };
 
-    if (files || !include) {
+    if ((files && files.length > 0) || !include) {
       throw new Error(
         'tsconfig.json files in the Kibana repo must use "include" keys and not "files"'
       );
     }
 
     this.directory = dirname(this.tsConfigPath);
     this.disableTypeCheck = options.disableTypeCheck || false;
+    this.disableNoEmit = options.disableNoEmit || false;
     this.name = options.name || relative(REPO_ROOT, this.directory) || basename(this.directory);
-    this.include = makeMatchers(this.directory, include);
+    this.include = makeMatchers(this.directory, include || []);
     this.exclude = makeMatchers(this.directory, exclude);
   }
 

src/dev/typescript/projects.ts

@@ -23,7 +23,12 @@ import { REPO_ROOT } from '../constants';
 import { Project } from './project';
 
 export const PROJECTS = [
-  new Project(resolve(REPO_ROOT, 'tsconfig.json')),
+  new Project(resolve(REPO_ROOT, 'tsconfig.oss.json'), {
+    disableNoEmit: true,
+  }),
+  new Project(resolve(REPO_ROOT, 'tsconfig.test.json'), {
+    disableNoEmit: true,
+  }),
   new Project(resolve(REPO_ROOT, 'test/tsconfig.json'), { name: 'kibana/test' }),
   new Project(resolve(REPO_ROOT, 'x-pack/tsconfig.json')),
   new Project(resolve(REPO_ROOT, 'x-pack/test/tsconfig.json'), { name: 'x-pack/test' }),

src/dev/typescript/run_type_check_cli.ts

@@ -79,7 +79,7 @@ export function runTypeCheckCli() {
     process.exit();
   }
 
-  const tscArgs = ['--noEmit', '--pretty', ...(opts['skip-lib-check'] ? ['--skipLibCheck'] : [])];
+  const tscArgs = ['--pretty', ...(opts['skip-lib-check'] ? ['--skipLibCheck'] : [])];
   const projects = filterProjectsByFlag(opts.project).filter((p) => !p.disableTypeCheck);
 
   if (!projects.length) {
@@ -90,7 +90,9 @@ export function runTypeCheckCli() {
   execInProjects(log, projects, process.execPath, (project) => [
     ...(project.name.startsWith('x-pack') ? ['--max-old-space-size=4096'] : []),
     require.resolve('typescript/bin/tsc'),
-    ...['--project', project.tsConfigPath],
+    ...(project.config.compilerOptions?.composite
+      ? ['-b', project.tsConfigPath]
+      : ['--noEmit', '--project', project.tsConfigPath]),
     ...tscArgs,
   ]);
 }

test/interpreter_functional/plugins/kbn_tp_run_pipeline/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

test/plugin_functional/plugins/app_link_test/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

test/plugin_functional/plugins/core_app_status/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

test/plugin_functional/plugins/core_plugin_a/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

test/plugin_functional/plugins/core_plugin_appleave/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

test/plugin_functional/plugins/core_plugin_b/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

test/plugin_functional/plugins/core_plugin_chromeless/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

test/plugin_functional/plugins/core_plugin_legacy/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

test/plugin_functional/plugins/core_plugin_static_assets/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true

test/plugin_functional/plugins/core_provider_plugin/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../../../tsconfig.json",
+  "extends": "../../../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./target",
     "skipLibCheck": true