[Monitoring] Added a case for Alerting if security/ssl is disabled by igoristic · Pull Request #71846 · elastic/kibana

igoristic · 2020-07-15T11:15:52Z

This was a slight oversight on our part with alerting. This basically ensures that the Monitoring ui still works if the security (or ssl) is disabled

elasticmachine · 2020-07-15T11:15:54Z

Pinging @elastic/stack-monitoring (Team:Monitoring)

chrisronline

Awesome, great work so far! I added a few suggestions/requests

x-pack/plugins/monitoring/server/plugin.ts

x-pack/plugins/monitoring/server/lib/elasticsearch/verify_alerting_security.ts

x-pack/plugins/monitoring/server/routes/api/v1/alerts/enable.ts

x-pack/plugins/monitoring/public/services/clusters.js

…lerting_security

kibanamachine · 2020-07-16T06:40:00Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 83b7a7f

Build metrics

async chunks size

id	value	diff	baseline
monitoring	1.2MB	+5.0KB	1.2MB

History

💔 Build #62145 failed b8a62c6
💚 Build #61875 succeeded e73d14e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

chrisronline · 2020-07-16T13:14:51Z

x-pack/plugins/monitoring/public/alerts/lib/security_toasts.tsx

+      <div>
+        <p>
+          {i18n.translate('xpack.monitoring.healthCheck.tlsAndEncryptionError', {
+            defaultMessage: `You must enable Transport Layer Security between Kibana and Elasticsearch 


I think we probably want to modify this message slightly since the user didn't do any explicit actions to enable alerting and will probably have no context.

Good point! What do you think about:

Alerting features are not working, because your security is currently insufficient. Please enable Transport Layer Security between Kibana and Elasticsearch, and configure an encryption key in your kibana.yml file.

Any suggestions would be helpful

I'm not sure honestly. cc @ravikesarwani @lcawl @gchaps for help here

chrisronline · 2020-07-16T13:15:20Z

x-pack/plugins/monitoring/public/alerts/lib/security_toasts.tsx

+      text: toMountPoint(
+        <div role="banner">
+          {i18n.translate('xpack.monitoring.healthCheck.encryptionErrorBeforeKey', {
+            defaultMessage: 'To create an alert, set a value for ',


Again, like before, the user will not understand what this means because they aren't consciously enabling or interacting with alerts

Ah you're right!

Wondering if we should just use one generic message from https://github.com/elastic/kibana/pull/71846/files#r455776054 if any of the two requirements (isSufficientlySecure, and hasPermanentEncryptionKey) are false?

Yea I'm not sure what we want to say here. Something like "out of the box alerts require x, y, z. See {link} on how to configure this". Honestly, I'd default to @ravikesarwani @lcawl @gchaps for help here on the messaging

Worked with @lcawl on the text. Does this work:

Alerting requires Transport Layer Security between Kibana and Elasticsearch and an encryption key in your kibana.yml file. Learn how to enable TLS.

where "Lean how to enable TLS" links to the documentation.

Yea, I think that works. i'll open a new PR for this

chrisronline

This functionally works, so let's merge it in. Can you create a follow up ticket to update the copy?

chrisronline · 2020-07-17T15:13:37Z

I'm going to merge this in so it's in the next BC

…lastic#71846) * Added a case for Alerting if security/ssl is disabled * Code feedback * Fixed types

…71846) (#72297) * Added a case for Alerting if security/ssl is disabled * Code feedback * Fixed types Co-authored-by: igoristic <igor.zaytsev.dev@gmail.com>

…71846) (#72295) * Added a case for Alerting if security/ssl is disabled * Code feedback * Fixed types Co-authored-by: igoristic <igor.zaytsev.dev@gmail.com>

chrisronline · 2020-07-17T16:56:16Z

Backport:

7.x: d3073f3
7.9: 8d5b16d

* master: [Maps] 7.9 documenation updates (elastic#71893) docs: ✏️ add "Explore underlying data" user docs (elastic#70807) [Security Solution][Exceptions] - Remove initial add exception item button in builder (elastic#72215) Fix indentation level in code exploration doc (elastic#72274) register graph usage (elastic#72041) [Monitoring] Added a case for Alerting if security/ssl is disabled (elastic#71846)

* master: [Observability] Remove app logos (elastic#72259) Fix float percentiles line chart (elastic#71902) update chromedriver to 84 (elastic#72228) [esArchiver] actually re-delete the .kibana index if we lose recreate race (elastic#72354) [Maps] convert SavedGisMap to TS (elastic#72286) [DOCS] Removes occurrences of X-Pack Security and Reporting (elastic#72302) use WORKSPACE env var for stack_functional_integration tests, fix navigate path (elastic#71908) [Monitoring] Fix issue with ES node detail status (elastic#72298) [SIEM] Updates consumer in export_rule archive (elastic#72324) [kbn/dev-utils] add RunWithCommands utility (elastic#72311) [Security Solution][Endpoint][Exceptions] Only write manifest to policy when there are changes (elastic#72000) skip flaky suite (elastic#72339) [ML] Fix annotations pagination & change labels from letters to numbers (elastic#72204) [Lens] Fix switching with layers (elastic#71982) [Maps] 7.9 documenation updates (elastic#71893) docs: ✏️ add "Explore underlying data" user docs (elastic#70807) [Security Solution][Exceptions] - Remove initial add exception item button in builder (elastic#72215) Fix indentation level in code exploration doc (elastic#72274) register graph usage (elastic#72041) [Monitoring] Added a case for Alerting if security/ssl is disabled (elastic#71846)

Added a case for Alerting if security/ssl is disabled

e73d14e

igoristic added review release_note:fix Team:Monitoring Stack Monitoring team v8.0.0 v7.9.0 labels Jul 15, 2020

igoristic requested a review from a team July 15, 2020 11:15

chrisronline suggested changes Jul 15, 2020

View reviewed changes

igoristic added 3 commits July 15, 2020 18:24

Merge branch 'master' of https://github.com/elastic/kibana into fix_a…

9e76d18

…lerting_security

Code feedback

4e701a5

Merge branch 'master' of https://github.com/elastic/kibana into fix_a…

b8a62c6

…lerting_security

igoristic requested a review from chrisronline July 16, 2020 01:15

igoristic added 2 commits July 16, 2020 00:46

Merge branch 'master' of https://github.com/elastic/kibana into fix_a…

91475c3

…lerting_security

Fixed types

83b7a7f

chrisronline suggested changes Jul 16, 2020

View reviewed changes

chrisronline approved these changes Jul 17, 2020

View reviewed changes

chrisronline merged commit 39381ca into elastic:master Jul 17, 2020

This was referenced Jul 17, 2020

[7.x] [Monitoring] Added a case for Alerting if security/ssl is disabled (#71846) #72295

Merged

[7.9] [Monitoring] Added a case for Alerting if security/ssl is disabled (#71846) #72297

Merged

chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Jul 17, 2020

[Monitoring] Added a case for Alerting if security/ssl is disabled (e…

9f81057

…lastic#71846) * Added a case for Alerting if security/ssl is disabled * Code feedback * Fixed types

chrisronline mentioned this pull request Jul 17, 2020

[Monitoring] Fix the messaging around needing TLS enabled #72310

Merged

igoristic deleted the fix_alerting_security branch July 20, 2020 04:35

igoristic added backported and removed review labels Jul 27, 2020

chrisronline mentioned this pull request Sep 10, 2020

[Monitoring] Fix UI error when alerting is not available #77179

Merged

Comments

Conversation

igoristic commented Jul 15, 2020

Uh oh!

elasticmachine commented Jul 15, 2020

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Jul 16, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

igoristic Jul 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

chrisronline commented Jul 17, 2020

Uh oh!

chrisronline commented Jul 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

igoristic Jul 16, 2020 •

edited

Loading