[7.x] [Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel (#67027)#71576
Merged
tsullivan merged 1 commit intoelastic:7.xfrom Jul 14, 2020
Conversation
… from Dashboard panel (elastic#67027) * [Reporting] Data formatting fixes for CSV export in Discover, CSV download from Dashboard panel commit e195964deaa3e7e8d94704d6514e01498c913a81 Author: Timothy Sullivan <tsullivan@elastic.co> Date: Mon Jul 13 10:17:36 2020 -0700 Squashed commit of the following: commit 87c9c496a6cccaf7a60a44b496f7c0c0423cd2ea Merge: d531101ab3 ed749eb Author: Timothy Sullivan <tsullivan@elastic.co> Date: Mon Jul 13 10:17:02 2020 -0700 Merge branch 'data/allow-custom-formatting' into reporting/csv-date-format-consistency commit d531101ab3c2f12628287bd5ad4a02bbf8b5c990 Merge: 400e2ffba4 17dc043 Author: Timothy Sullivan <tsullivan@elastic.co> Date: Mon Jul 13 10:15:38 2020 -0700 Merge branch 'master' into reporting/csv-date-format-consistency commit ed749eb Author: Timothy Sullivan <tsullivan@elastic.co> Date: Mon Jul 13 10:12:28 2020 -0700 move shared code to common commit 4e5eebd Author: Timothy Sullivan <tsullivan@elastic.co> Date: Mon Jul 13 09:07:32 2020 -0700 3td time api doc chagens commit 34df331 Merge: 54fa2fe 17dc043 Author: Timothy Sullivan <tsullivan@elastic.co> Date: Mon Jul 13 08:50:21 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 400e2ffba4546cf78c53ce96b45a59878f0df076 Author: Timothy Sullivan <tsullivan@elastic.co> Date: Sun Jul 12 21:29:34 2020 -0700 [Reporting] Data formatting fixes for CSV export in Discover, CSV download from Dashboard panel commit 54fa2fe Merge: 1b6e9e8 e1253ed Author: Elastic Machine <elasticmachine@users.noreply.github.com> Date: Sun Jul 12 22:18:38 2020 -0600 Merge branch 'master' into data/allow-custom-formatting commit 1b6e9e8 Author: Timothy Sullivan <tsullivan@elastic.co> Date: Fri Jul 10 15:03:08 2020 -0700 weird api change needed but no real diff commit fc9ff7b Merge: 736e9ee 66c531d Author: Timothy Sullivan <tsullivan@elastic.co> Date: Fri Jul 10 14:51:51 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 736e9ee Author: Timothy Sullivan <tsullivan@elastic.co> Date: Thu Jul 9 17:43:10 2020 -0700 fix path for tests commit 1bebcc8 Author: Timothy Sullivan <tsullivan@elastic.co> Date: Thu Jul 9 17:25:09 2020 -0700 re-use public code in server, add test commit 1e1d3c5 Author: Timothy Sullivan <tsullivan@elastic.co> Date: Thu Jul 9 16:35:30 2020 -0700 rerun api changes commit 231f793 Author: Timothy Sullivan <tsullivan@elastic.co> Date: Thu Jul 9 16:31:55 2020 -0700 fix src/plugins/data/public/field_formats/constants.ts commit d42275c Merge: 206aed6 8e2277a Author: Timothy Sullivan <tsullivan@elastic.co> Date: Thu Jul 9 16:01:40 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 206aed6 Merge: 5aa2d80 09da110 Author: Timothy Sullivan <tsullivan@elastic.co> Date: Thu Jul 9 15:03:12 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 5aa2d80 Author: Timothy Sullivan <tsullivan@elastic.co> Date: Wed Jul 8 12:12:31 2020 -0700 api doc changes commit 76e2c30 Merge: 1789afc 595e9c2 Author: Timothy Sullivan <tsullivan@elastic.co> Date: Wed Jul 8 12:04:12 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 1789afc Author: Timothy Sullivan <tsullivan@elastic.co> Date: Fri Jul 3 11:23:03 2020 -0700 simplify changes commit 6428455 Author: Timothy Sullivan <tsullivan@elastic.co> Date: Thu Jul 2 16:05:57 2020 -0700 add more to tests - need help though commit 6aacfbd Author: Timothy Sullivan <tsullivan@elastic.co> Date: Thu Jul 2 12:04:28 2020 -0700 [Data Plugin] Allow server-side date formatters to accept custom timezone When Advanced Settings shows the date format timezone to be "Browser," this means nothing to field formatters in the server-side context. The field formatters need a way to accept custom format parameters. This allows a server-side module that creates a FieldFormatMap to set a timezone as a custom parameter. When custom formatting parameters exist, they get combined with the defaults. * comments
Contributor
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: