Skip to content

[Observability] Change appLink passing the date range#71259

Merged
cauemarcondes merged 13 commits intoelastic:masterfrom
cauemarcondes:obs-applink
Jul 14, 2020
Merged

[Observability] Change appLink passing the date range#71259
cauemarcondes merged 13 commits intoelastic:masterfrom
cauemarcondes:obs-applink

Conversation

@cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Jul 9, 2020

closes #71051

@cauemarcondes cauemarcondes requested a review from a team July 9, 2020 15:26
@cauemarcondes cauemarcondes requested review from a team as code owners July 9, 2020 15:26
@botelastic botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jul 9, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 9, 2020

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 9, 2020

Pinging @elastic/uptime (Team:uptime)

shahzad31
shahzad31 approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM !!

afgomez
afgomez approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logs changes LGTM

sorenlouv
sorenlouv reviewed Jul 9, 2020
View reviewed changes
sorenlouv
sorenlouv approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sorenlouv
sorenlouv reviewed Jul 9, 2020
View reviewed changes
sorenlouv
sorenlouv reviewed Jul 9, 2020
View reviewed changes
sorenlouv
sorenlouv reviewed Jul 10, 2020
View reviewed changes
@cauemarcondes
Copy link
Contributor Author

cauemarcondes commented Jul 12, 2020

@elasticmachine merge upstream

@cauemarcondes
Copy link
Contributor Author

cauemarcondes commented Jul 13, 2020

retest

@cauemarcondes
Copy link
Contributor Author

cauemarcondes commented Jul 13, 2020

@elasticmachine merge upstream

1 similar comment
@cauemarcondes
Copy link
Contributor Author

cauemarcondes commented Jul 14, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 14, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 3374b2d into elastic:master Jul 14, 2020
@cauemarcondes cauemarcondes deleted the obs-applink branch July 14, 2020 09:05
sorenlouv pushed a commit to sorenlouv/kibana that referenced this pull request Jul 14, 2020
@cauemarcondes @elasticmachine
[Observability] Change appLink passing the date range (elastic#71259)
7416ea1 
* changing apm appLink

* changing apm appLink

* removing title from api

* adding absolute and relative times

* addressing pr comments

* addressing pr comments

* addressing pr comments

* fixing TS issues

* addressing pr comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@sorenlouv sorenlouv mentioned this pull request Jul 14, 2020
Merged
@sorenlouv
Copy link
Member

sorenlouv commented Jul 14, 2020

💚 Backport successful

The PR was backported to the following branches:

gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 14, 2020
@gmmorris
Merge branch 'master' into task-manager/batch-update-delete
b51cefe 
* master: (314 commits)
  [APM] Use status_code field to calculate error rate (elastic#71109)
  [Observability] Change appLink passing the date range (elastic#71259)
  [Security] Add Timeline improvements (elastic#71506)
  adjust vislib bar opacity (elastic#71421)
  Fix ScopedHistory mock and adapt usages (elastic#71404)
  [Security Solution] Add hook for reading/writing resolver query params (elastic#70809)
  [APM] Bug fixes from ML integration testing (elastic#71564)
  [Discover] Add caused_by.type and caused_by.reason to error toast modal (elastic#70404)
  [Security Solution] Add 3rd level breadcrumb to admin page (elastic#71275)
  [Security Solution][Exceptions] Exception modal bulk close alerts that match exception attributes (elastic#71321)
  Change signal.rule.risk score mapping from keyword to float (elastic#71126)
  Added help text where needed on connectors and alert actions UI (elastic#69601)
  [SIEM][Detections] Value Lists Management Modal (elastic#67068)
  [test] Skips test preventing promotion of ES snapshot elastic#71582
  [test] Skips test preventing promotion of ES snapshot elastic#71555
  [ILM] Fix alignment of the timing field (elastic#71273)
  [SIEM][Detection Engine][Lists] Adds the ability for exception lists to be multi-list queried. (elastic#71540)
  initial telemetry setup (elastic#69330)
  [Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel (elastic#67027)
  Search across spaces (elastic#67644)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 14, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into fix/managemen…
b4c4f76 
…t-apps-page-titles

* 'master' of github.com:elastic/kibana: (88 commits)
  [ML] Functional tests - disable DFA creation and cloning tests
  [APM] Use status_code field to calculate error rate (elastic#71109)
  [Observability] Change appLink passing the date range (elastic#71259)
  [Security] Add Timeline improvements (elastic#71506)
  adjust vislib bar opacity (elastic#71421)
  Fix ScopedHistory mock and adapt usages (elastic#71404)
  [Security Solution] Add hook for reading/writing resolver query params (elastic#70809)
  [APM] Bug fixes from ML integration testing (elastic#71564)
  [Discover] Add caused_by.type and caused_by.reason to error toast modal (elastic#70404)
  [Security Solution] Add 3rd level breadcrumb to admin page (elastic#71275)
  [Security Solution][Exceptions] Exception modal bulk close alerts that match exception attributes (elastic#71321)
  Change signal.rule.risk score mapping from keyword to float (elastic#71126)
  Added help text where needed on connectors and alert actions UI (elastic#69601)
  [SIEM][Detections] Value Lists Management Modal (elastic#67068)
  [test] Skips test preventing promotion of ES snapshot elastic#71582
  [test] Skips test preventing promotion of ES snapshot elastic#71555
  [ILM] Fix alignment of the timing field (elastic#71273)
  [SIEM][Detection Engine][Lists] Adds the ability for exception lists to be multi-list queried. (elastic#71540)
  initial telemetry setup (elastic#69330)
  [Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel (elastic#67027)
  ...

# Conflicts:
#	x-pack/plugins/index_management/public/application/index.tsx
cauemarcondes added a commit that referenced this pull request Jul 14, 2020
@sorenlouv @cauemarcondes @elasticmachine
[Observability] Change appLink passing the date range (#71259) (#71605)
ef57e1d 
* changing apm appLink

* changing apm appLink

* removing title from api

* adding absolute and relative times

* addressing pr comments

* addressing pr comments

* addressing pr comments

* fixing TS issues

* addressing pr comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 14, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
d2c732f 
* master: (72 commits)
  [test] Skips test preventing promotion of ES snapshot elastic#71612
  [Logs UI] Remove UUID from Alert Instances (elastic#71340)
  [Metrics UI] Remove UUID from Alert Instance IDs (elastic#71335)
  [ML] Functional tests - disable DFA creation and cloning tests
  [APM] Use status_code field to calculate error rate (elastic#71109)
  [Observability] Change appLink passing the date range (elastic#71259)
  [Security] Add Timeline improvements (elastic#71506)
  adjust vislib bar opacity (elastic#71421)
  Fix ScopedHistory mock and adapt usages (elastic#71404)
  [Security Solution] Add hook for reading/writing resolver query params (elastic#70809)
  [APM] Bug fixes from ML integration testing (elastic#71564)
  [Discover] Add caused_by.type and caused_by.reason to error toast modal (elastic#70404)
  [Security Solution] Add 3rd level breadcrumb to admin page (elastic#71275)
  [Security Solution][Exceptions] Exception modal bulk close alerts that match exception attributes (elastic#71321)
  Change signal.rule.risk score mapping from keyword to float (elastic#71126)
  Added help text where needed on connectors and alert actions UI (elastic#69601)
  [SIEM][Detections] Value Lists Management Modal (elastic#67068)
  [test] Skips test preventing promotion of ES snapshot elastic#71582
  [test] Skips test preventing promotion of ES snapshot elastic#71555
  [ILM] Fix alignment of the timing field (elastic#71273)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

+1 more reviewer

@afgomez afgomez afgomez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Observability Landing - Milestone 1 release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Observability] Change appLink passing the date range

6 participants

@cauemarcondes @elasticmachine @kibanamachine @sorenlouv @afgomez @shahzad31

Comments