[Index Management] Fix broken app links#71007
[Index Management] Fix broken app links#71007alisonelizabeth merged 3 commits intoelastic:masterfrom
Conversation
alisonelizabeth
added
Feature:Index Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
I didn't really review the code, just glanced through out of curiosity and had one comment.
| <EuiDescriptionListDescription> | ||
| {ilmPolicy && ilmPolicy.name ? ( | ||
| <EuiLink href={getILMPolicyPath(ilmPolicy.name)}>{ilmPolicy.name}</EuiLink> | ||
| <EuiLink |
There was a problem hiding this comment.
Just a note that we need an href here too, so users can copy the url or open the link in a new tab. If you grep for reactRouterNavigate you can see how we use this utility in various plugins to provide both an href and an onClick.
There was a problem hiding this comment.
@cjcenizal thanks for pointing this out! From what I can see, reactRouterNavigate doesn't work when navigating to other apps. I came across #67697, which suggests using history.parentHistory. This would work, however, it is private in ScopedHistory. I will change it back to a href for now, but there will be a full page refresh.
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
Tested locally and code changes look good! Great work @alisonelizabeth !
In ILM and CCR, you should be able to view related indices. This appears to be a regression of #67940.
I'm not 100% on how the regression came from that particular PR - looks like I'm missing something! Was it because of the introduction of includeHiddenIndices?
|
Thanks for the review @jloleysens!
It looks like you changed the way we get the filter value. So instead of |
5 participants
This PR fixes some broken cross-app linking in Index Management.
When an index template has an associated ILM policy, the link in the details panel should direct the user to ILM.
In ILM and CCR, you should be able to view related indices. This appears to be a regression of [Index Management] Add data streams functionality to indices tab #67940.
ILM
CCR
Other changes:
I also noticed we have both a
navigationandroutingfile. I combined these into one file; let me know if there are any objections.